[ARO] Ensure worker_profile is not None before getting the subnets from #16309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennerv
force-pushed
the
aro-fetch-subnets-fix
branch
2 times, most recently
from
6593fc1 to
7b64cfc
Compare
bennerv
force-pushed
the
aro-fetch-subnets-fix
branch
from
7b64cfc to
e9eeb75
Compare
Member
Author
|
cc @jim-minter and @mjudeikis |
Collaborator
|
ARO |
Contributor
|
@fengzhou-msft lets merge this please :) |
yungezz
approved these changes
Dec 23, 2020
fengzhou-msft
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upstreams Azure/ARO-RP#1227 to ensure that worker_profiles is not None before attempting to access it.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.