{Network} Fix live test #16315
Merged
{Network} Fix live test #16315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haroldrandom
force-pushed
the
fix-network-test
branch
from
c5e7fc9 to
77c8f20
Compare
haroldrandom
commented
Dec 18, 2020
| }) | ||
|
|
||
| # this command failed as service cannot find component of application insights | ||
| self.cmd('monitor private-link-scope scoped-resource create -g {rg} -n {assigned_ws} --linked-resource {workspace_id} --scope-name {scope}', checks=[ |
Contributor
Author
There was a problem hiding this comment.
FYI. same buggy as https://github.com/Azure/azure-cli/pull/16299/files#r544913673
haroldrandom
requested review from
jsntcy,
kairu-ms and
msyyc
as code owners
Collaborator
|
Network |
kairu-ms
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #15621
According to the report, network already meets the requirement 95%+.
After this fix, network should be able to be close to 100% pass rate
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.