{Network} Migrate network SDK that is used by some other modules to track2 #16350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsntcy
requested review from
Juliehzl,
evelyn-ys,
fengzhou-msft,
haroldrandom,
kairu-ms,
msyyc,
qwordy and
zhoxing-ms
as code owners
Collaborator
|
Network |
msyyc
approved these changes
Dec 24, 2020
evelyn-ys
approved these changes
Dec 24, 2020
Member
|
Should we update yaml files? |
Contributor
There is no yaml file for live scenario tests. |
Juliehzl
approved these changes
Dec 24, 2020
Contributor
Juliehzl
left a comment
Juliehzl
left a comment
There was a problem hiding this comment.
LGTM. But please make sure exception structure is right when querying error info.
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are main changes for Network migration to track2:
begin_xxx_xxx, for example in track1, the name iscreate_or_update; while in track2, the name isbegin_create_or_update.HttpResponseErrorinstead ofCloudError.Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.