{Compute} Fix tests #16425
Merged
{Compute} Fix tests #16425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Compute |
yungezz
reviewed
Jan 6, 2021
| recommended=recommendation, disallowed=Disallowed(disk_types=disallowed_disk_types), | ||
| purchase_plan=purchase_plan, location=location, eula=eula, tags=(tags or {}), | ||
| hyper_vgeneration=hyper_v_generation, features=feature_list) | ||
| hyper_v_generation=hyper_v_generation, features=feature_list) |
| self.cmd('sig image-definition create -g {rg} --gallery-name {g1} --gallery-image-definition image --os-type linux -p publisher1 -f offer1 -s sku1 --features "IsSecureBootSupported=false IsMeasuredBootSupported=false" --hyper-v-generation V2', checks=[ | ||
| self.check('features[0].name', 'IsSecureBootSupported'), | ||
| self.check('features[0].value', 'false'), | ||
| self.check('features[0].value', 'false', False), |
Member
Author
There was a problem hiding this comment.
Service change. It returns "False" not "false"
Member
There was a problem hiding this comment.
can the test util be changed to support case-insensitive compare?
Member
Author
There was a problem hiding this comment.
The "False" I added means case sensitive = False. Default value is True.
yungezz
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
azure/cli/command_modules/vm/tests/latest/test_vm_commands.py::VMManagedDiskScenarioTest::test_vm_disk_max_shares_etc
azure/cli/command_modules/vm/tests/latest/test_vm_commands.py::DiskAccessTest::test_disk_access
azure/cli/command_modules/vm/tests/latest/test_vm_commands.py::VMGalleryImage::test_gallery_specialized
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.