{Storage} Enable logging for track2 data plane operations #16439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juliehzl
requested review from
evelyn-ys,
jsntcy and
zhoxing-ms
as code owners
Collaborator
|
Storage |
jiasli
reviewed
Jan 8, 2021
| sas_token = kwargs.pop('sas_token', None) | ||
|
|
||
| # Enable NetworkTraceLoggingPolicy which logs all headers (except Authorization) without being redacted | ||
| client_kwargs['logging_enable'] = True |
Member
There was a problem hiding this comment.
The same line is repeated 3 times. Is it possible to extract a common util func?
We can also azure.cli.core.commands.client_factory._prepare_client_kwargs_track2 directly if it is suitable.
evelyn-ys
approved these changes
Jan 8, 2021
jiasli
reviewed
Jan 12, 2021
| token_credential = kwargs.pop('token_credential', None) | ||
| sas_token = kwargs.pop('sas_token', None) | ||
|
|
||
| client_kwargs.update(_prepare_client_kwargs_track2(cli_ctx)) |
Member
There was a problem hiding this comment.
We can simply use client_kwargs = _prepare_client_kwargs_track2(cli_ctx) if there is no modification before this line.
Contributor
Author
There was a problem hiding this comment.
good catch. updated
jiasli
approved these changes
Jan 12, 2021
jiasli
reviewed
Jan 12, 2021
|
|
||
| from azure.cli.core.commands.client_factory import get_mgmt_service_client, get_data_service_client | ||
| from azure.cli.core.commands.client_factory import get_mgmt_service_client, get_data_service_client, \ | ||
| _prepare_client_kwargs_track2 |
Member
There was a problem hiding this comment.
Good to know _prepare_client_kwargs_track2 is useful for date-plane SDKs.
Contributor
Author
No. They are for different kwargs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In track2 SDK, we have to configure the client to enable logging. Otherwise cx could not see the rest info.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.