-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[NetAppFiles] Update azure-mgmt-netapp version to 0.15.0 #16467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameters added to custom commands - Active directory: security_operators - Volume: smb_encryption - Volume: smb_continuously_available Help updated Tests added and updated New recordings made for all the tests
Collaborator
|
NetAppFiles |
Contributor
Author
kairu-ms
approved these changes
Jan 19, 2021
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/test_account_commands.py
Outdated
Show resolved
Hide resolved
Contributor
Author
msyyc
approved these changes
Jan 22, 2021
Contributor
Author
Contributor
Author
|
@msyyc Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update azure-mgmt-netapp dependency to version 0.15.0 and additions from that version added.
This version includes minor optional parameter additions.
Component netappfiles is no longer marked as preview.
Help was updated according to changes.
Tests added and updated and new recordings made for all the tests.
Minor bugfix for finding correct resource group for subnet when creating volume.
Testing Guide
History Notes
[NetAppFiles] az netappfiles account ad add: parameter security-operators added.
[NetAppFiles] az netappfiles volume create: parameter smb-continuously-available added.
[NetAppFiles] az netappfiles volume create: parameter smb-encryption added.
[NetAppFiles] az netappfiles: No longer in preview mode.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.