Skip to content

Conversation

@hildurhodd
Copy link
Contributor

@hildurhodd hildurhodd commented Jan 8, 2021

Description

Update azure-mgmt-netapp dependency to version 0.15.0 and additions from that version added.
This version includes minor optional parameter additions.

Component netappfiles is no longer marked as preview.

Help was updated according to changes.
Tests added and updated and new recordings made for all the tests.
Minor bugfix for finding correct resource group for subnet when creating volume.

Testing Guide

History Notes

[NetAppFiles] az netappfiles account ad add: parameter security-operators added.
[NetAppFiles] az netappfiles volume create: parameter smb-continuously-available added.
[NetAppFiles] az netappfiles volume create: parameter smb-encryption added.
[NetAppFiles] az netappfiles: No longer in preview mode.


This checklist is used to make sure that common guidelines for a pull request are followed.

Parameters added to custom commands
 - Active directory: security_operators
 - Volume: smb_encryption
 - Volume: smb_continuously_available
Help updated
Tests added and updated
New recordings made for all the tests
@hildurhodd hildurhodd closed this Jan 8, 2021
@hildurhodd hildurhodd reopened this Jan 8, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Jan 8, 2021

NetAppFiles

@yonzhan yonzhan requested review from jsntcy, kairu-ms and msyyc January 8, 2021 16:45
@yonzhan yonzhan added this to the S182 milestone Jan 8, 2021
@hildurhodd
Copy link
Contributor Author

@kairu-ms @msyyc @jsntcy can we get this moving, please?

@hildurhodd
Copy link
Contributor Author

Thank you @kairu-ms, I have fixed what you pointed out.
We still need code owner review @msyyc

@hildurhodd
Copy link
Contributor Author

@msyyc @kairu-ms thank you. Can you merge this? I am not allowed to

@hildurhodd
Copy link
Contributor Author

@msyyc Can this be merged?

@kairu-ms kairu-ms merged commit 378f521 into Azure:dev Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants