Skip to content

Conversation

@madsd
Copy link
Contributor

@madsd madsd commented Jan 13, 2021

Description
This PR adds support for ASE v3 in preview. From a command perspective, a "kind" parameters is added to az appservice ase create. Default is ASEv2 to avoid breaking changes, but you can specify ASEv3 explicitly to create this.
Includes changes to az appservice plan create/update to support the IsolatedV2 SKUs that are associated with ASEv3 and some minor changes to fix #16026 and fix #16118
Adds command az appservice ase create-inbound-services to support creating the inbound services needed for ASEv3 during the preview period. This is expected to be deprecated after GA. Inbound services include

  • Ensure subnet private endpoint network policy is disabled
  • Create private endpoint
  • Create private DNS zone (.appserviceenvironment.net)
  • Link zone to virtual network
  • Create A records for *, @ and *.scm in zone

Finally the PR aims to align the affected commands with the new Error Handling guidelines

Testing Guide
Assuming a resource group with a virtual network and two empty subnet of at least size /24

az appservice ase create -n <ase-name> -g <resource-group> --subnet <outbound-subnet-name> --vnet-name <vnet-name> --kind ASEv3

az appservice ase create-inbound-services -n <ase-name> -g <resource-group> --subnet <inbound-subnet-name> --vnet-name <vnet-name>

History Notes

[AppService] az appservice ase/plan ASEv3 support
[AppService] Fix #16026 and #16118 for az appservice plan


This checklist is used to make sure that common guidelines for a pull request are followed.

@madsd madsd requested review from Juliehzl and qwordy as code owners January 13, 2021 10:59
@yonzhan
Copy link
Collaborator

yonzhan commented Jan 13, 2021

AppService

@yungezz yungezz added the App Services az appservice label Jan 14, 2021
@panchagnula panchagnula added this to the S182 milestone Jan 16, 2021
@qwordy qwordy merged commit edf9ed4 into Azure:dev Jan 18, 2021
@madsd madsd deleted the asev3-support branch January 18, 2021 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

App Services az appservice

Projects

None yet

5 participants