-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[AppService] BREAKING CHANGE: Fix regression where you can't use a runtime version with a space in the name #16528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AppService] BREAKING CHANGE: Fix regression where you can't use a runtime version with a space in the name #16528
Conversation
|
@calvinsID should we remove "" as a delimiter completely or can we just make this stricter. If we see multiple spaces in a case the runtime Value has a space & space is being used as delimiter can we do something to consider the last space in the string to be the delimiter? |
|
@panchagnula good idea I'll change so that if there are other delimiters first, we ignore the other delimiters. That way if a runtime which has spaces is used, it will work with other delimiters |
Sounds good @calvinsID also may be update the help doc to clarify that space is a supported delimiter & add examples on how to use this. Also if a runtime has space in language should't the recommendation be to enclose them in single or double quotes "Java SE" so if the command is used as so az webapp create -n {} -g {} --runtime "'Java SE" |
|
@panchagnula if the runtime has a space in the language it might be messy to allow the use of space as a delimiter, ex. |
…t already contain spaces
e92aa6a to
7ddb19b
Compare
…r test to succeed
Agreed Please update help with some examples with different delimiters & add a test case for command with runtime with language value only like 'Java SE' i.e if we allow runtime version with language value only where we use default version value? otherwise change looks good to me. |
|
Added examples in the help text. We currently don't allow language value only like "Java SE" though we can add this in a future PR |
panchagnula
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for jumping on this fix so quickly from the time I assigned the issue to you :)
Description
Fixes issue #16066
Before, az webapp up/create allowed you to specify
--runtimeparameter with delimiters "|", " ", and ":".This parsing caused runtimes with a space (" ") in it to not be parsed correctly.
In this PR, removing ability to use space (" ") as a delimiter so that runtimes with a space in it get parsed correctly again
Testing Guide
az webapp create -n {} -g {} --runtime "'java|1.8|Java SE|8" --os-type Windowsshould workThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.