[ACR] add --allow-trusted-services support #16530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| help='Default action to apply when no rule matches. Only applicable to Premium SKU.') | ||
| c.argument('public_network_enabled', get_three_state_flag(), help="Allow public network access for the container registry. The Default is allowed") | ||
| c.argument('public_network_enabled', get_three_state_flag(), help="Allow public network access for the container registry. The Default is to allow public access.") | ||
| c.argument('allow_trusted_services', get_three_state_flag(), is_preview=True, help="Allow trusted Azure Services to access network restricted registries. For more information, please visit https://aka.ms/acr/trusted-services. The default is to allow.") |
Member
There was a problem hiding this comment.
Help message says The default is to allow.
For acr update, there should be no default values for the options in update commands.
For acr create, I don't see the logic to default to allow. Is it handled on service side?
Contributor
Author
There was a problem hiding this comment.
yes, this is the default on the service side. Should I remove this?
Member
There was a problem hiding this comment.
You can keep The default is to allow for acr create, but should remove it for acr update. If allow_trusted_services is none in update command, then the setting will not be changed.
Contributor
Author
There was a problem hiding this comment.
yes this makes sense. I see what you mean. Thanks for the clarification (I used same help text for both)
fengzhou-msft
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the option
--allow-trusted-servicestoaz acr createandaz acr update. By default ACR allows trusted azure services to access network restricted registries.Testing Guide
History Notes
[ACR] az acr create / update: add --allow-trusted-services. This parameter determines whether trusted azure services are allowed to access network restricted registries. The default is to allow.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.