[ACR] az acr connected-registry install: deprecate ACR_SYNC_TOKEN_USERNAME from the output #16561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can we update the notes as follows? History Notes [ACR connected-registry] |
Contributor
Author
|
@fengzhou-msft can you help review the pr please? It's ready for merge |
Collaborator
|
ACR |
mnltejaswini
approved these changes
Jan 19, 2021
Member
|
@yonzhan can you merge the pr? |
Collaborator
|
@fengzhou-msft to help with this PR. |
yungezz
approved these changes
Jan 26, 2021
fengzhou-msft
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ACR_SYNC_TOKEN_USERNAME is being deprecated from the install command group. The new value will be ACR_SYNC_TOKEN_NAME
Testing Guide
az acr connected-registry install info -n -r
az acr connected-registry install renew-credentials -n -r
History Notes
[ACR]
az acr connected-registry install info: Add new keyACR_SYNC_TOKEN_NAMEwith the same value asACR_SYNC_TOKEN_USERNAME. A warning that the latter will be deprecated is displayed.[ACR]
az acr connected-registry install renew-credentials: Add new keyACR_SYNC_TOKEN_NAMEwith the same value asACR_SYNC_TOKEN_USERNAME. A warning that the latter will be deprecated is displayed.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.