Skip to content

Conversation

@madsd
Copy link
Contributor

@madsd madsd commented Jan 18, 2021

Description
This PR adds support for setting Linux as the initial OS support for ASEv3 to fix #16509. This is not relevant for ASEv3.
It also improves the new functionality of az appservice ase create-inbound-services to allow the Private DNS Zone to be created for Internal ASEv2 as well, and to be able to only create the private endpoint for ASEv3 and skip DNS services (to support custom DNS).

Testing Guide
The --skip-dns will skip the creation of Private DNS Zone and records

az appservice ase create -n <ase-name> -g <resource-group> --subnet <outbound-subnet-name> --vnet-name <vnet-name> --kind ASEv3

az appservice ase create-inbound-services -n <ase-name> -g <resource-group> --subnet <inbound-subnet-name> --vnet-name <vnet-name> --skip-dns

Creating an ASEv2 and creating the private dns components (zone and records)

az appservice ase create -n <ase-name> -g <resource-group> --subnet <outbound-subnet-name> --vnet-name <vnet-name>

az appservice ase create-inbound-services -n <ase-name> -g <resource-group> --subnet <inbound-subnet-name> --vnet-name <vnet-name>

History Notes

[App Service] Add support for os-preference to fix #16509
[App Service] Improve behavior of appservice ase create-inbound-services to allow skipping DNS services and support DNS for ASEv2


This checklist is used to make sure that common guidelines for a pull request are followed.

@madsd madsd requested review from Juliehzl and qwordy as code owners January 18, 2021 19:02
@yonzhan
Copy link
Collaborator

yonzhan commented Jan 18, 2021

App Service

@yungezz yungezz added the App Services az appservice label Jan 19, 2021
@yungezz
Copy link
Member

yungezz commented Jan 19, 2021

hi @qwordy could you pls help to review? thanks

@qwordy qwordy merged commit 36bcdae into Azure:dev Jan 19, 2021
@madsd madsd deleted the ase-improvements branch January 19, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

App Services az appservice

Projects

None yet

Development

Successfully merging this pull request may close these issues.

webapp: Create an app service environment with Os support as linux

4 participants