Skip to content

Conversation

@dbradish-microsoft
Copy link
Contributor

@dbradish-microsoft dbradish-microsoft commented Jan 20, 2021

Description
Per request, the deprecation warning for az openshift reference content needs to be updated.

@dbradish-microsoft dbradish-microsoft changed the title [OpenShift] update of az openshift warning [OpenShift] update of az openshift deprecation warning Jan 20, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Jan 20, 2021

OpenShift

@yungezz yungezz added the AKS az aks/acs/openshift label Jan 21, 2021
@yungezz
Copy link
Member

yungezz commented Jan 21, 2021

hi @fengzhou-msft could you pls add openshift command owner for review also? thanks

@dbradish-microsoft dbradish-microsoft marked this pull request as ready for review January 26, 2021 17:29
@dbradish-microsoft
Copy link
Contributor Author

@jiasli , @fengzhou-msft , Please see email thread with subject "Breadth Coverage baseline RP review" and modify this PR as you see fit. I don't take PRs in this repo any further than 'ready for review'.

@fengzhou-msft
Copy link
Member

@olga-mir can you help review this PR?

@fengzhou-msft
Copy link
Member

Added deprecate_info so that when running an openshift command, the following warning will be shown:

This command is implicitly deprecated because command group 'openshift' is deprecated and will be removed in a future release. Use 'aro' instead.

@fengzhou-msft
Copy link
Member

@jim-minter can you help review this PR?

@jim-minter
Copy link
Member

@dbradish-microsoft please sync with @sakthi-vetrivel on this - it's her call.

@dbradish-microsoft
Copy link
Contributor Author

@sakthi-vetrivel , this PR has been approved by the Azure CLI engineering team. We'll move forward to merge it early next week unless you request updates.

Kindly,

Delora

@fengzhou-msft
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@fengzhou-msft fengzhou-msft merged commit b73474d into Azure:dev Feb 24, 2021
@dbradish-microsoft dbradish-microsoft deleted the dbradish_azOpenshiftLSupdate branch January 6, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS az aks/acs/openshift

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants