[AppService] az webapp up/az webapp create: Fix nonetype errors #16605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 20, 2021
Closed
Collaborator
|
AppService |
qwordy
reviewed
Jan 21, 2021
|
|
||
| elif plan_info.is_xenon: # windows container webapp | ||
| site_config.windows_fx_version = _format_fx_version(deployment_container_image_name) | ||
| if deployment_container_image_name: |
Member
There was a problem hiding this comment.
Is it a valid condition that deployment_container_image_name is None?
Contributor
There was a problem hiding this comment.
this is an optional parameter on the command.
qwordy
approved these changes
Jan 21, 2021
Member
|
Wait for Sisira's review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix null reference errors in
az webapp upandaz webapp createCloses #15752, #16565, #16061, #16475
az webapp upwill try and find appservice plan in the wrong resource groupaz webapp createif deployment_container_image_name is not suppliedTesting Guide
az webapp upaz webapp createThese two scenarios shouldn't give nonetype error
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.