{Packaging} Bump msal and remove msal-extensions #16672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengzhou-msft
requested review from
Juliehzl,
evelyn-ys,
houk-ms,
jiasli and
jsntcy
as code owners
Collaborator
|
bump msal |
jiasli
reviewed
Jan 26, 2021
jiasli
reviewed
Jan 26, 2021
yungezz
added
Compute
jiasli
reviewed
Jan 26, 2021
ivanst0
reviewed
Feb 11, 2021
fengzhou-msft
changed the title
jiasli
approved these changes
Feb 23, 2021
|
Thank you @fengzhou-msft! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #15212
With
msal 1.9.0, theClientApplication.acquire_token_by_refresh_tokenfunction supports getting ssh cert with a refresh token, so the hack of using the inheritedAdalRefreshTokenBasedClientApplicationcan be removed.Testing Guide
msalis now only used in vm ssh scenario. To test the scenario, follow the steps in login-using-aad beforeUsing Conditional Access, then install the ssh extension:az extension add -s https://azcliprod.blob.core.windows.net/cli-extensions/ssh-0.1.4-py3-none-any.whl -yRun the command to login to vm with AAD:
az ssh vm -g <rg> -n <vm_name>History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.