[AppService]: fix ##8743- az webapp deploy #16715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shrishrirang
approved these changes
Jan 28, 2021
Collaborator
|
AppService |
panchagnula
reviewed
Jan 29, 2021
panchagnula
reviewed
Jan 29, 2021
panchagnula
suggested changes
Jan 29, 2021
Contributor
panchagnula
left a comment
panchagnula
left a comment
There was a problem hiding this comment.
Changes look good.
but we are missing
- test cases
- function app equivalent support - assuming this works for function apps as well.
- Also add "PREVIEW" tag attribute to this command.
Contributor
Author
working on Testcases. Will address the remaining review comments in my next PR. |
Contributor
One more thing to add is --slot support on the commands - especially if API supports this. |
Contributor
Author
|
@panchagnula - please review |
qwordy
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#8743- az webapp deploy
Testing Guide
az webapp deploy --resource-group ResouceGroup --name AppName --src-path SourcePath --type static --target-path staticfiles/test.txt
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.