[KeyVault] BREAKING CHANGE: az keyvault role assignment/definition list: roleDefinitionName should be roleName in command output
#16781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
we'll need communicate with Amit about the change |
Contributor
Author
Sure, i'll do that |
Contributor
Author
|
Have confirmed with service team about the breaking changes, they agree to fix. @yungezz @fengzhou-msft Please find time to review. |
yungezz
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
roleNameis the name of a role, which is provided by user as the display name.roleDefinitionNameis the name of a role definition, which is a GUID. It's calledroleDefinitionNamein the request body while is callednamein response.This pr provides two improvements
az keyvault role assignment list, theroleDefinitionNameactually isroleName, this pr fixes the problem.previously
now
az keyvault role definition list, so that users won't be confused by the two names.previously
now
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.