{Extension} Add retry when getting extension index #16847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengzhou-msft
requested review from
Juliehzl,
evelyn-ys,
houk-ms,
jiasli and
jsntcy
as code owners
Collaborator
|
Extension |
jiasli
reviewed
Feb 8, 2021
Comment on lines
36
to
41
| if try_number == TRIES - 1: | ||
| msg = ERR_TMPL_NO_NETWORK.format(str(err)) | ||
| raise CLIError(msg) | ||
| import time | ||
| time.sleep(0.5) | ||
| continue |
Member
There was a problem hiding this comment.
We can combine (requests.exceptions.ConnectionError, requests.exceptions.HTTPError) and ValueError as the handling code is the exactly the same.
jiasli
reviewed
Feb 9, 2021
Co-authored-by: Jiashuo Li <[email protected]>
jiasli
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're seeing increasing failures of
Test Extensions Loading Python36task in CI when downloading the extension index file. Add retry to mitigate the issue while we trying to figure out the root cause.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.