Skip to content

[AKS] Add support for SGX addon 'confcom' #16869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengzhou-msft merged 8 commits into from
Feb 19, 2021
Merged

[AKS] Add support for SGX addon 'confcom' #16869

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
50fce17
Add confcom addon support
Pengpeng-Microsoft Feb 8, 2021
76819e9
Add test recordings and fix a default behavior bug for addon confcom
ppwang Feb 9, 2021
4c3fb81
Revert unrelated test coverage files
ppwang Feb 9, 2021
e7ba55e
Fix test pipeline failures
ppwang Feb 10, 2021
388f686
Fix typo
ppwang Feb 10, 2021
be59443
Add missing aks enable-addons help for sgx quote helper
ppwang Feb 11, 2021
19683e7
Fix lint issues
ppwang Feb 11, 2021
669443b
Change to use ValidationError
ppwang Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Change to use ValidationError
  • Loading branch information
@ppwang
ppwang committed Feb 18, 2021
commit 669443b07453f19d562ace327392bcf4e4a2b9ad
8 changes: 4 additions & 4 deletions src/azure-cli/azure/cli/command_modules/acs/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2843,10 +2843,10 @@ def _update_addons(cmd, instance, subscription_id, resource_group_name, name, ad
addon_profile.config[CONST_INGRESS_APPGW_WATCH_NAMESPACE] = appgw_watch_namespace
elif addon == CONST_CONFCOM_ADDON_NAME:
if addon_profile.enabled:
raise CLIError('The confcom addon is already enabled for this managed cluster.\n'
'To change confcom configuration, run '
f'"az aks disable-addons -a confcom -n {name} -g {resource_group_name}" '
'before enabling it again.')
raise ValidationError('The confcom addon is already enabled for this managed cluster.',
recommendation='To change confcom configuration, run '
f'"az aks disable-addons -a confcom -n {name} -g {resource_group_name}" '
'before enabling it again.')
addon_profile = ManagedClusterAddonProfile(
enabled=True, config={CONST_ACC_SGX_QUOTE_HELPER_ENABLED: "false"})
if enable_sgxquotehelper:
Expand Down