-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Storage] Fix #16872: az storage blob now (2.19) requires login even if connection-string is provided #16885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Storage |
64f6f4e to
c859211
Compare
evelyn-ys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do azcopy.remove have the same issue? I remember in #16519 both remove and sync are modified due to permissions.
azure-cli/src/azure-cli/azure/cli/command_modules/storage/operations/azcopy.py
Lines 57 to 60 in bc4d70c
| sas_token = _generate_sas_token(cmd, client.account_name, client.account_key, service=service, | |
| resource_types='co', | |
| permissions='rdl') | |
| azcopy.remove(_add_url_sas(target, sas_token), flags=flags) |
Good point! updated and added test. |
Description
Fix #16872
Testing Guide
az account clearaz storage blob syncwith account key or connection stringHistory Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.