Skip to content

Conversation

@Juliehzl
Copy link
Contributor

@Juliehzl Juliehzl commented Feb 10, 2021

Description

Fix #16872

Testing Guide

az account clear
az storage blob sync with account key or connection string

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 10, 2021

Storage

@yonzhan yonzhan added this to the S183 - For Ignite milestone Feb 10, 2021
@Juliehzl Juliehzl force-pushed the fix16872 branch 2 times, most recently from 64f6f4e to c859211 Compare February 10, 2021 04:22
@Juliehzl Juliehzl changed the base branch from release to dev February 10, 2021 05:04
Copy link
Member

@evelyn-ys evelyn-ys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do azcopy.remove have the same issue? I remember in #16519 both remove and sync are modified due to permissions.

sas_token = _generate_sas_token(cmd, client.account_name, client.account_key, service=service,
resource_types='co',
permissions='rdl')
azcopy.remove(_add_url_sas(target, sas_token), flags=flags)

@Juliehzl
Copy link
Contributor Author

Juliehzl commented Feb 19, 2021

Do azcopy.remove have the same issue? I remember in #16519 both remove and sync are modified due to permissions.

sas_token = _generate_sas_token(cmd, client.account_name, client.account_key, service=service,
resource_types='co',
permissions='rdl')
azcopy.remove(_add_url_sas(target, sas_token), flags=flags)

Good point! updated and added test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

az storage blob now (2.19) requires login even if connection-string is provided

4 participants