[#114438129]address code analysis errors by pylints #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yugangw-msft
changed the title
src/azure/cli/_argparse.py
Outdated
yugangw-msft
changed the title
yugangw-msft
added a commit
that referenced
this pull request
Feb 29, 2016
[#114438129]address code analysis errors by pylints
| # For all codes, run 'pylint --list-msgs' or go to 'http://pylint-messages.wikidot.com/all-codes' | ||
| # C0111 Missing docstring | ||
| # C0103 Invalid %s name "%s" | ||
| # C0303 Trailing whitespace |
Contributor
Author
There was a problem hiding this comment.
We will do it in a separate PR to bring it back
yugangw-msft
added a commit
to yugangw-msft/azure-cli
that referenced
this pull request
Sep 22, 2017
yugangw-msft
added a commit
that referenced
this pull request
Sep 22, 2017
* Initial support for VM and single zone VMSS (#14) * wire up the initial zone support work * add output * add tests * disable package verifications * use a private copy of network sdk with zone support (#15) * Support for zoned public IP. Make global zone_type and zones_type. (#16) * Support for zoned public IP. Make global zone_type and zones_type. * Code review feedback. * apply api version range on vm zone test (#19) * show zone in the table output (#20) * install: support to build out a msi installer from local sources (#17) * doc:add command examples using availability zones (#21) * Installer: build debian bundle from a local clone (#28) * skip a few expeneive travis builds * test: update tests to work with new azure-mgmt-compute with zone support * network: support zone in network lb create (#37) * VNet peering examples. (#51) * Add BrazilUS and Dogfood cloud config files. (#50) * undo all changes specifically for private repository * fix help per review feedback * fix lint error * use newer nrp sdk version
DaeunYim
pushed a commit
to DaeunYim/azure-cli
that referenced
this pull request
Sep 12, 2020
Refactoring flexible server create
00Kai0
pushed a commit
to 00Kai0/azure-cli
that referenced
this pull request
Apr 7, 2021
* image-copy: first commit * fixes after @derekbekoe reviewed * remove dead code * round of small fixes * remove test file * merg commit * add image-copy to index.json * Add examples to help * fix package names to allow index ci to pass * fix whitespace * image-copy: remove mincli from index.json
00Kai0
pushed a commit
to 00Kai0/azure-cli
that referenced
this pull request
Apr 7, 2021
* NFSAAS-1708 add initial version of anf cli extension * NFSAAS-1708 lint fixes * NFSAAS-1708 code owner * NFSAAS-1708 update from review comments * NFSAAS-1708 update from review comments * NFSAAS-1708 update with code review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments (Azure#9) * Nfsaas 1708 initial cli extension (Azure#10) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#11) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#13) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#14) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#16) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#17) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments
00Kai0
pushed a commit
to 00Kai0/azure-cli
that referenced
this pull request
Apr 7, 2021
* NFSAAS-1708 add initial version of anf cli extension * NFSAAS-1708 lint fixes * NFSAAS-1708 code owner * NFSAAS-1708 update from review comments * NFSAAS-1708 update from review comments * NFSAAS-1708 update with code review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments (Azure#9) * Nfsaas 1708 initial cli extension (Azure#10) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#11) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#13) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#14) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#16) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#17) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 add anf to cli extension index * NFSAAS-1708 add anf to cli extension index (Azure#18) * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index (Azure#22) Plus correct some help validation errors * Nfsaas 1708 add index (Azure#23) * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * Nfsaas 1708 add index (Azure#24) * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * Nfsaas 1708 add index (Azure#25) * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * Nfsaas 1708 add index (Azure#26) * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * Nfsaas 1708 add index (Azure#27) * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors
00Kai0
pushed a commit
to 00Kai0/azure-cli
that referenced
this pull request
Apr 7, 2021
* Azure quantum extension v0 (Azure#2) Initial version. * Fixing style issues * Incorporating feedback (Azure#6) * readme * feedback * Help * Make storage account optional (Azure#7) * Storage is now optional (Azure#8) * Making storage an argument, not an env variable (Azure#9) * Adding implementation of 'az quantum workspace delete' command. * Setting new temporary version. * Fixing missing file in test change * Adding details to README.md (Azure#5) * Updating generated files for Azure Quantum resource manager from new swagger file version * Remove manual edit of generated file. * Updating generated files for Azure Quantum data plane from new swagger file version * Updating generated files for Azure Quantum resource manager from new swagger file version. (2020-11-06) (Azure#13) * Adding implementation of 'az quantum workspace create' command. (Azure#14) Adding initial implementation of 'az quantum workspace create' command. ----------------------------------- Command az quantum workspace create : Creates a new Azure Quantum workspace. Command group 'quantum' is in preview. It may be changed/removed in a future release. Arguments --location -l : Location. Values from: az account list-locations. You can configure the default location using az configure --defaults location=<location>. --resource-group -g : Name of resource group. You can configure the default group using az configure --defaults group=<name>. --storage_account -sa : Name of the storage account to be used by a quantum workspace. --workspace-name -w : Name of the Quantum Workspace. You can configure the default workspace using az quantum workspace set. * Update Azure CLI quantum extension to multi-region (Azure#17) This change will set the URL for the data plan API accordingly with a location parameter specified as part of the command. * Updating swagger files per commit 44563991425d862ba4e8090a2b5b6caf8333600c in azure-rest-api-specs-pr. (Azure#16) Updating swagger files per commit 44563991425d862ba4e8090a2b5b6caf8333600c in azure-rest-api-specs-pr. * Fixing tests for multi-region URL change on Az CLI quantum extension (Azure#19) Fixing tests for multi-region URL change on Az CLI quantum extension * Incorporating ARM feedback (Azure#18) * Picking up latest changes from swagger after ARM feedback * updated create_or_update * run command * Setting default location in workspace calls if not specified (Azure#20) * updating python azure quantum rest client (Azure#21) * Update generated files from swagger file (Version 2021-01-11) (Azure#22) * Hot fixes on December 2020 release of Azure CLI extension (Azure#23) * Fixing issue with over specification of location * Updating version information of extension * Update CLI with generated clients from more recent swagger files (Azure#24) - Data plane updated to official swagger file (2021-01-11 19:01:32 UTC) on azure-rest-api-specs @ 98ae52b87af2f172f84f3305f8fe46f819543a49. - Resource manager updated to candidate swagger file (2021-01-15 19:35:41 UTC) on anpaz:quantum/resource-manager @ a9a9e271c13500aa54fdbb1bcb656eb61d82d38b. * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <[email protected]> * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <[email protected]> * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <[email protected]> * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <[email protected]> * Require location as a mandatory parameter in workspace specification (Azure#25) * Make location mandatory in commands * Update test recordings * Resetting the version history for the released version. * Fix description of workspace clear command * Updatig Readme file to RST format. * Update Readme file per pull request comments. * Fixing az quantum run and execute commands to include location parameter * Performing role assignment on storage account on workspace creation. (Azure#29) * Add warning message about providers during workspace creation (Azure#30) * Enable command az quantum workspace quotas (Azure#31) * Removing extra space in Readme.rst Co-authored-by: Feiyue Yu <[email protected]> * Fix punctuation in Readme.rst Co-authored-by: Feiyue Yu <[email protected]> * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <[email protected]> * Update src/quantum/azext_quantum/_params.py Co-authored-by: Feiyue Yu <[email protected]> * First round of code review feedback on Readme.rst * Improve code readability on job commands * Avoid IndexError in case of malformed URL * Extended info on targetId parameter * Add help to each individual command * Reorganize sections in Readme.rst and merge in a single set of instructions. * Static analysis fixes * Fix CLI Linter errors * Fix CLI Linter errors. Part 2 * Fix typo in show command. * Fix show command for Linter * Use standard name for show command method * Modify workspace create test to skip role assignment * Update tests with workspace names used currently. * Update test recordings. * Set subscription for the recordings. * Update test recordings. * Update QDK version number * Remove asserts and checks for subscription * Experiment: Remove check for preview subscription * Refresh recordings with current test values. * Update recordings after typo fix. * Remove commented out API that references subscription * Enable QuantumJobsScenarioTest.test_submit_args only on live mode Co-authored-by: Ricardo Espinoza <[email protected]> Co-authored-by: Feiyue Yu <[email protected]>
sturrent
added a commit
to sturrent/azure-cli
that referenced
this pull request
Oct 21, 2025
Three critical bugs were discovered and fixed that prevented User-Defined Route (UDR) analysis from functioning in the integrated CLI command: Bug Azure#17: RouteTableAnalyzer Not Integrated - RouteTableAnalyzer was copied but never instantiated in orchestrator - Added Phase 3 for route table analysis - Renumbered all phases from 1/8-8/8 to 1/9-9/9 - Embedded route_table_analysis into outbound_analysis['udr_analysis'] - Updated report_generator to accept route_table_analysis parameter Bug Azure#18: Route Table Field Case Sensitivity - Added dual checking for both 'vnetSubnetId' and 'vnet_subnet_id' - Ensures compatibility with different SDK data sources - Handles camelCase/snake_case variations robustly Bug Azure#19: Wrong Dictionary Key for Network Client - Fixed clients.get('network') → clients.get('network_client') - RouteTableAnalyzer was receiving None instead of NetworkManagementClient - This was the critical blocker preventing subnet lookups Testing Results: - aks-overlay cluster now correctly detects UDR with firewall route - Warning generated: "Default route (0.0.0.0/0) redirects all internet traffic through virtual appliance at 192.168.11.1" - Route table 'sec-udr' found and analyzed - Virtual appliance routes properly categorized Files Modified: - orchestrator.py: Added RouteTableAnalyzer integration, fixed client key - route_table_analyzer.py: Added dual-case field checking - report_generator.py: Added route_table_analysis parameter - PHASE6-PROGRESS.md: Documented all three bugs Impact: UDR analysis now fully functional, critical networking configurations are properly detected and reported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.