Skip to content

Conversation

@houk-ms
Copy link
Contributor

@houk-ms houk-ms commented Feb 20, 2021

Description

This PR bumps msrest to 0.6.21, as azure-keyvault-administration==4.0.0b3 depends on msrest>=0.6.21. The keyvault package is used for the support of keyvault custom role definition feature.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@houk-ms
Copy link
Contributor Author

houk-ms commented Feb 20, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@houk-ms houk-ms changed the title {Packaging}: Bump msrest to 0.6.21 {Packaging}: Bump msrest to 0.6.21 Feb 20, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Feb 20, 2021

@jiasli for awareness

@yungezz yungezz added the KeyVault az keyvault label Feb 22, 2021
MarkupSafe==1.1.1
mock==4.0.2
msrest==0.6.18
msrest==0.6.21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no change need in setup.py?

Copy link
Contributor Author

@houk-ms houk-ms Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, msrest version is not specified explicitly in setup.py, so azure-keyvault-administration==4.0.0b3 there will make sure msrest>=0.6.21 when installed by pip

@houk-ms houk-ms merged commit f1a9713 into Azure:dev Feb 23, 2021
@fengzhou-msft
Copy link
Member

Please pay attention to the results of scheduled live test on Friday morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

KeyVault az keyvault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants