[IoTCentral] az iot central app: Address several S360 fixes
#17022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with Original dev branch
Sync with remote master
Sync with remote branch
Sync with dev
Sync with remote
Collaborator
|
IoTCentral |
Contributor
Author
|
@zhoxing-ms please let us know what we need to do to complete this so that we can make it to the S183 milestone. (we really want to make it to this train) |
digimaun
reviewed
Feb 24, 2021
digimaun
approved these changes
Feb 24, 2021
Contributor
Author
Member
|
Once @zhoxing-ms approves we should be able to merge. |
Collaborator
|
@zhoxing-ms please help with this PR with high priority. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
zhoxing-ms
reviewed
Feb 25, 2021
Co-authored-by: Xing Zhou <[email protected]>
Contributor
Author
|
ok. Updated the HISTORY as suggested. |
zhoxing-ms
reviewed
Feb 25, 2021
zhoxing-ms
reviewed
Feb 25, 2021
zhoxing-ms
changed the title
az iot central app: address several S360 fixes
zhoxing-ms
changed the title
az iot central app: address several S360 fixesaz iot central app: Address several S360 fixes
zhoxing-ms
approved these changes
Feb 25, 2021
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
Looks like we got all our approvals. Please merge this PR whenever you guys feel comfortable. Thanks! Edit: guess we need to wait for the validation to be passed. Let's do that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main purpose of this PR is to address several S360 fixes with the inconsistency between our swagger and our RP response. This PR will also make sure our command az iot central app will be using the latest python packages that we just released. The S360 issue included resourceType should be camel case, appTemplateName field should be name in appTemplate API, add new industry and locations field in appTemplate API, add new origin and properties field in operations API, remove the need of checking etag when updating the existing iotc app command.
Note: By removing the etag check in az cli iot central app update command, it allows us to remove the etag field from RP response later on. Otherwise the az cli iot central app update command will effectively fail.
Testing Guide
We have re-record the tests with live validation and it passed.
History Notes
[IoTCentral]
az iot central app: Address several S360 fixes[IoTCentral]
az iot central app update: Remove the need of checking etag when updating the existing iotc app.[IoTCentral] Change the resourceType (IotApps) to be in camel case.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.