Skip to content

[Network] az network public-ip create: Support '--zone 1 2 3' after '2020-08-01' #17043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyyc merged 17 commits into from
Feb 24, 2021
Merged

[Network] az network public-ip create: Support '--zone 1 2 3' after '2020-08-01' #17043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0be2ba7
test part1
msyyc Feb 9, 2021
b632a7e
test part2
msyyc Feb 10, 2021
915de53
test part 3
msyyc Feb 10, 2021
923c493
test part 4
msyyc Feb 10, 2021
0b1023b
test part 6
msyyc Feb 18, 2021
db035f1
test part 7
msyyc Feb 18, 2021
442bfc2
test part 8
msyyc Feb 19, 2021
3a04d5f
test part 9
msyyc Feb 20, 2021
39d4608
part 10
msyyc Feb 20, 2021
273b8fe
test part 11
msyyc Feb 20, 2021
741e527
delete unnecessary code
msyyc Feb 20, 2021
51304e2
style
msyyc Feb 20, 2021
16d4468
reduce os disk comsumption
msyyc Feb 20, 2021
7efc0aa
public-ip zone
msyyc Feb 23, 2021
d3ce5ca
style
msyyc Feb 23, 2021
ff20172
merge
msyyc Feb 23, 2021
cb70899
confict
msyyc Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/azure-cli/azure/cli/command_modules/network/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,12 @@ def load_arguments(self, _):
app_gateway_name_type = CLIArgumentType(help='Name of the application gateway.', options_list='--gateway-name', completer=get_resource_name_completion_list('Microsoft.Network/applicationGateways'), id_part='name')
express_route_link_macsec_cipher_type = CLIArgumentType(get_enum_type(ExpressRouteLinkMacSecCipher))
express_route_link_admin_state_type = CLIArgumentType(get_enum_type(ExpressRouteLinkAdminState))
zone_compatible_type = CLIArgumentType(
options_list=['--zone', '-z'],
nargs='+',
help='Space-separated list of availability zones into which to provision the resource.',
choices=['1', '2', '3']
)

# region NetworkRoot
with self.argument_context('network') as c:
Expand Down Expand Up @@ -1670,7 +1676,8 @@ def load_arguments(self, _):
c.argument('reverse_fqdn', help='Reverse FQDN (fully qualified domain name).')
c.argument('dns_name', help='Globally unique DNS entry.')
c.argument('idle_timeout', help='Idle timeout in minutes.')
c.argument('zone', zone_type, min_api='2017-06-01')
c.argument('zone', zone_type, min_api='2017-06-01', max_api='2020-07-01')
c.argument('zone', zone_compatible_type, min_api='2020-08-01')
c.argument('ip_tags', nargs='+', min_api='2017-11-01', help="Space-separated list of IP tags in 'TYPE=VAL' format.", validator=validate_ip_tags)

with self.argument_context('network public-ip create') as c:
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/network/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,7 +1019,7 @@ def _inform_coming_breaking_change_for_public_ip(namespace):
logger.warning('[Coming breaking change] In the coming release, the default behavior will be changed as follows'
' when sku is Standard and zone is not provided:'
' For zonal regions, you will get a zone-redundant IP indicated by zones:["1","2","3"];'
' For non-zonal regions, you will get a non zone-redundant IP indicated by zones:[].')
' For non-zonal regions, you will get a non zone-redundant IP indicated by zones:null.')


def process_route_table_create_namespace(cmd, namespace):
Expand Down
Loading