[ACR] 'az acr connected-registry install info/renew-credentials': Provide connection string in installation command #17152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xyxyxyxyxyxy
changed the title
jaysterp
reviewed
Mar 1, 2021
src/azure-cli/azure/cli/command_modules/acr/connected_registry.py
Outdated
Show resolved
Hide resolved
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
src/azure-cli/azure/cli/command_modules/acr/connected_registry.py
Outdated
Show resolved
Hide resolved
rosanch
suggested changes
Mar 24, 2021
src/azure-cli/azure/cli/command_modules/acr/connected_registry.py
Outdated
Show resolved
Hide resolved
rosanch
suggested changes
Mar 29, 2021
xyxyxyxyxyxy
changed the title
xyxyxyxyxyxy
changed the title
rosanch
approved these changes
Mar 31, 2021
northtyphoon
suggested changes
Apr 5, 2021
src/azure-cli/azure/cli/command_modules/acr/connected_registry.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acr/connected_registry.py
Outdated
Show resolved
Hide resolved
northtyphoon
reviewed
Apr 5, 2021
src/azure-cli/azure/cli/command_modules/acr/connected_registry.py
Outdated
Show resolved
Hide resolved
mnltejaswini
reviewed
Apr 5, 2021
src/azure-cli/azure/cli/command_modules/acr/connected_registry.py
Outdated
Show resolved
Hide resolved
mnltejaswini
reviewed
Apr 5, 2021
src/azure-cli/azure/cli/command_modules/acr/connected_registry.py
Outdated
Show resolved
Hide resolved
northtyphoon
reviewed
Apr 5, 2021
northtyphoon
approved these changes
Apr 6, 2021
Member
|
The PR is ready for merge. |
fengzhou-msft
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the output into connection string for acr connected-registry install command.
Remove old output vars, and check the parent gateway endpoint to use a place holder for an empty string (dynamic parent login server).
Testing Guide
az acr connected-registry install info -n -r
az acr connected-registry install renew-credentials -n -r
History Notes
[ACR] BREAKING CHANGE: az acr connected-registry install info: Replace keys ACR_REGISTRY_NAME, ACR_SYNC_TOKEN_NAME, ACR_SYNC_TOKEN_PASSWORD, ACR_PARENT_GATEWAY_ENDPOINT, and ACR_PARENT_PROTOCOL with a new connected string key, ACR_REGISTRY_CONNECTION_STRING.
[ACR] BREAKING CHANGE: az acr connected-registry install renew-credentials: Replace keys ACR_REGISTRY_NAME, ACR_SYNC_TOKEN_NAME, ACR_SYNC_TOKEN_PASSWORD, ACR_PARENT_GATEWAY_ENDPOINT, and ACR_PARENT_PROTOCOL with a new connected string key, ACR_REGISTRY_CONNECTION_STRING.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.