[Core] Add spinner progress bar for long running operation

[Juliehzl]

Description

This PR is one part for progress bar project.
As we already in beta version for several months, I plan to move indeterminate progress bar with spinner to all long running operation in azure cli as shown below:

But I have to mention for commands like network vnet create, which is long running operation, but not hornor CLI LongRunningOperation class, will not have progress bar.

Testing Guide

az storage account create
az vm create

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• The PR title and description has followed the guideline in Submitting Pull Requests.

• I adhere to the Command Guidelines.

• I adhere to the Error Handling Guidelines.

[yonzhan]

Core

[jiasli]

Consider dropping cli_ctx reference if it is unused.

[Juliehzl]

It is used in L181 to get progress controller

[evelyn-ys]

I compared the implement before and found that the original way support spinner already. There's just a bug winthin LongRunningOperation. L123 shows that cli_ctx.get_progress_controller() will init progress and create a new spinner each time when called.

azure-cli/src/azure-cli-core/azure/cli/core/__init__.py

Lines 118 to 124 in 7d0dd03

	def get_progress_controller(self, det=False):
	import azure.cli.core.commands.progress as progress
	if not self.progress_controller:
	self.progress_controller = progress.ProgressHook()
	self.progress_controller.init_progress(progress.get_progress_view(det))
	return self.progress_controller

LRO calls self.cli_ctx.get_progress_controller().begin(), self.cli_ctx.get_progress_controller().add(message='Running') or self.cli_ctx.get_progress_controller().end() to update progress. But each time updating the progress, the progress will be initialized. So the behavior will look like no animation.

To support spinning for LRO, we only need to log progress_controller = self.cli_ctx.get_progress_controller() and then call progress_controller.begin(), progress_controller.add(message='Running') and progress_controller.end() within LongRunningOperation.

[Juliehzl]

I compared the implement before and found that the original way support spinner already. There's just a bug winthin LongRunningOperation. L123 shows that cli_ctx.get_progress_controller() will init progress and create a new spinner each time when called.

azure-cli/src/azure-cli-core/azure/cli/core/__init__.py

Lines 118 to 124 in 7d0dd03

	def get_progress_controller(self, det=False):
	import azure.cli.core.commands.progress as progress
	if not self.progress_controller:
	self.progress_controller = progress.ProgressHook()
	self.progress_controller.init_progress(progress.get_progress_view(det))
	return self.progress_controller

LRO calls self.cli_ctx.get_progress_controller().begin(), self.cli_ctx.get_progress_controller().add(message='Running') or self.cli_ctx.get_progress_controller().end() to update progress. But each time updating the progress, the progress will be initialized. So the behavior will look like no animation.

To support spinning for LRO, we only need to log progress_controller = self.cli_ctx.get_progress_controller() and then call progress_controller.begin(), progress_controller.add(message='Running') and progress_controller.end() within LongRunningOperation.

Yes, there is an issue in previous design. Here I don't use add() because I want to expand progress bar capability with update_progress(), which could have more progress bar UI.