Skip to content

[Interactive] Fix #16931: Fix KeyError in az interactive --update #17389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengzhou-msft merged 2 commits into from
Mar 29, 2021
Merged

[Interactive] Fix #16931: Fix KeyError in az interactive --update #17389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b732f72
only reload when module is already imported
fengzhou-msft Mar 23, 2021
e1a45dc
Update CODEOWNERS
fengzhou-msft Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
/scripts/live_test @qwordy
/src/azure-cli-testsdk/ @jsntcy @jiasli @kairu-ms @qwordy
/src/azure-cli-core/ @jiasli @Juliehzl @fengzhou-msft @evelyn-ys @jsntcy @houk-ms
/src/azure-cli-core/azure/cli/core/extension/ @msyyc
/src/azure-cli-core/azure/cli/core/extension/ @msyyc @fengzhou-msft
/src/azure-cli/azure/cli/command_modules/acr/ @djyou @fengzhou-msft @yungezz
/src/azure-cli/azure/cli/command_modules/acs/ @rjtsdl @fengzhou-msft
/src/azure-cli/azure/cli/command_modules/advisor/ @Prasanna-Padmanabhan
Expand Down
6 changes: 2 additions & 4 deletions src/azure-cli-core/azure/cli/core/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,11 +715,9 @@ def get_command_type_kwarg(custom_command=False):

def reload_module(module):
# reloading the imported module to update
try:
if module in sys.modules:
from importlib import reload
except ImportError:
pass # for python 2
reload(sys.modules[module])
reload(sys.modules[module])


def get_default_admin_username():
Expand Down