[AKS] az aks create: add support for --private-dns-zone and --fqdn-subdomain feature #17430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levimm
changed the title
levimm
changed the title
yungezz
requested review from
Pengpeng-Microsoft,
norshtein and
samkreter
and removed request for
norshtein and
samkreter
gossion
approved these changes
Mar 26, 2021
feiskyer
approved these changes
Mar 26, 2021
added 2 commits
March 29, 2021 11:28
fengzhou-msft
approved these changes
Mar 29, 2021
Contributor
Author
|
@fengzhou-msft Could you help merge the pr? It's ready now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr copies feature
--private-dns-zoneand--fqdn-subdomainfrom aks extension because we're going to GA these two features.Testing Guide
History Notes
[AKS] az aks create: add support for --private-dns-zone and --fqdn-subdomain feature
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.