-
Notifications
You must be signed in to change notification settings - Fork 3.3k
{Network} Fix network tests which will cause CI fail in Eventgrid module #17434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Network |
Member
|
Very clear, comprehensive and comprehensible analysis! Nice work! |
3 tasks
3 tasks
msyyc
approved these changes
Mar 25, 2021
kairu-ms
approved these changes
Mar 25, 2021
jiasli
approved these changes
Mar 25, 2021
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
#17432 (comment) solves the CI failure: |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently CI fails like this:
This PR fix CI.
Cause
From pipeline log we can find that all eventgrid module tests fail. It says no match requests found for api version
2020-04-01-preview, only api version2020-10-15-previewfound.But api version
2020-10-15-previewis expected as #17361 has upgraded eventgrid from2020-04-01-previewto2020-10-15-preview. The CI tests failed because all eventgrid commands used the code in eventgrid extension which hasn't upgraded version.Then we found that eventgrid extension was added manually in network module(L851):
azure-cli/src/azure-cli/azure/cli/command_modules/network/tests/latest/test_private_endpoint_commands.py
Lines 847 to 855 in 983cb41
The eventgrid extension should be removed after network tests end, but the removing code(L854) was commented out in #17290
So if CI run network tests before eventgrid tests, eventgrid tests will be redirected to eventgrid extension code, which will cause failure after the eventgrid in main repo has upgraded version.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.