Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review comments
  • Loading branch information
VidyaKukke committed Mar 25, 2021
commit 7cd749b65c76f699557c57b48dca080082ddf4f5
2 changes: 1 addition & 1 deletion linter_exclusions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1650,7 +1650,7 @@ eventgrid partner namespace event-channel create:
activation_expiration_date:
rule_exclusions:
- option_length_too_long
desination_topic_name:
destination_topic_name:
rule_exclusions:
- option_length_too_long
destination_resource_group_name:
Expand Down
21 changes: 6 additions & 15 deletions src/azure-cli/azure/cli/command_modules/eventgrid/custom.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
# pylint: disable=too-many-lines

import re
import sys
from knack.log import get_logger
from knack.util import CLIError
from msrestazure.tools import parse_resource_id
Expand Down Expand Up @@ -221,7 +220,7 @@ def cli_domain_create_or_update(
client,
resource_group_name,
domain_name,
location,
location=None,
tags=None,
input_schema=EVENTGRID_SCHEMA,
input_mapping_fields=None,
Expand Down Expand Up @@ -380,7 +379,7 @@ def cli_partner_namespace_create_or_update(
client,
resource_group_name,
partner_namespace_name,
location,
location=None,
partner_registration_id,
tags=None):

Expand Down Expand Up @@ -412,7 +411,7 @@ def cli_event_channel_create_or_update(
partner_topic_source,
destination_subscription_id,
destination_resource_group_name,
desination_topic_name,
destination_topic_name,
activation_expiration_date=None,
partner_topic_description=None,
publisher_filter=None):
Expand All @@ -422,7 +421,7 @@ def cli_event_channel_create_or_update(
destination_info = EventChannelDestination(
azure_subscription_id=destination_subscription_id,
resource_group=destination_resource_group_name,
partner_topic_name=desination_topic_name)
partner_topic_name=destination_topic_name)

event_channel_filter = None
if publisher_filter is not None:
Expand Down Expand Up @@ -457,7 +456,7 @@ def cli_partner_topic_create_or_update(
client,
resource_group_name,
partner_topic_name,
location,
location=None,
tags=None):

partner_topic_info = PartnerTopic(
Expand Down Expand Up @@ -568,7 +567,7 @@ def cli_system_topic_create_or_update(
client,
resource_group_name,
system_topic_name,
location,
location=None,
topic_type,
source,
tags=None,
Expand Down Expand Up @@ -658,8 +657,6 @@ def cli_system_topic_event_subscription_create_or_update( # pylint: disable=t
deadletter_identity_endpoint=None,
storage_queue_msg_ttl=storage_queue_msg_ttl,
enable_advanced_filtering_on_arrays=enable_advanced_filtering_on_arrays)
print('print systemtopic create filter params', file=sys.stderr)
print(event_subscription_info.filter.enable_advanced_filtering_on_arrays, file=sys.stderr)

return client.create_or_update(
resource_group_name,
Expand Down Expand Up @@ -1141,9 +1138,6 @@ def cli_system_topic_event_subscription_update(
storage_queue_msg_ttl=storage_queue_msg_ttl,
enable_advanced_filtering_on_arrays=enable_advanced_filtering_on_arrays)

print('print systemtopic update params', file=sys.stderr)
print(params.filter.enable_advanced_filtering_on_arrays, file=sys.stderr)

return client.update(
resource_group_name,
system_topic_name,
Expand Down Expand Up @@ -1368,9 +1362,6 @@ def _update_event_subscription_internal( # pylint: disable=too-many-locals,too-

event_subscription_filter.enable_advanced_filtering_on_arrays = enable_advanced_filtering_on_arrays

print('printing enable_advanced_filtering_on_arrays value', file=sys.stderr)
print(event_subscription_filter.enable_advanced_filtering_on_arrays, file=sys.stderr)

if advanced_filter is not None:
event_subscription_filter.advanced_filters = advanced_filter

Expand Down