{Core} Refactor dynamic extension install in _check_value
#17474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengzhou-msft
requested review from
Juliehzl,
evelyn-ys,
jiasli and
jsntcy
as code owners
jiasli
reviewed
Apr 1, 2021
jiasli
reviewed
Apr 1, 2021
Comment on lines
+542
to
+338
| recommender = CommandRecommender(*command_arguments, error_msg, cli_ctx) | ||
| recommender.set_help_examples(self.get_examples(command_name_inferred)) | ||
| recommendations = recommender.provide_recommendations() | ||
| if recommendations: | ||
| az_error.set_aladdin_recommendation(recommendations) | ||
|
|
||
| # remind user to check extensions if we can not find a command to recommend | ||
| if isinstance(az_error, CommandNotFoundError) \ | ||
| and not az_error.recommendations and self.prog == 'az' \ | ||
| and use_dynamic_install == 'no': | ||
| az_error.set_recommendation(EXTENSION_REFERENCE) |
Member
There was a problem hiding this comment.
Maybe we can move these lines to another file too.
fengzhou-msft
force-pushed
the
refactor_dynamic_install
branch
from
76ef8ec to
871d1b7
Compare
msyyc
approved these changes
Apr 8, 2021
jiasli
approved these changes
Apr 13, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the logic of dynamic extension install to a new fucntion
_check_value_in_extensions. It will exit if the parser error is caused by an extension not installed, and simplified error handling code below by removing thenot caused_by_extension_not_installedcheck based on this change.This PR also adds the check whether the latest version of the extension is already installed to avoid infinite loop in cases like #17497
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.