{EventGrid} Add support for delivery attribute mapping, topicKind #17496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VidyaKukke
changed the title
Collaborator
|
EventGrid |
kairu-ms
reviewed
Mar 30, 2021
evelyn-ys
reviewed
Mar 30, 2021
kairu-ms
reviewed
Mar 30, 2021
evelyn-ys
reviewed
Mar 30, 2021
kairu-ms
reviewed
Mar 30, 2021
kairu-ms
reviewed
Mar 30, 2021
evelyn-ys
reviewed
Mar 30, 2021
Comment on lines
+366
to
+368
| c.argument('enable_advanced_filtering_on_arrays', is_preview=True, arg_type=get_three_state_flag(), | ||
| options_list=['--enable-advanced-filtering-on-arrays', '--enable-af-arr'], arg_group="Filtering", | ||
| help="Allows advanced filters to be evaluated against an array of values instead of expecting a singular value.") |
Member
There was a problem hiding this comment.
This parameter has already be defined in self.argument_context('eventgrid')(See Line227) so you don't need to redefine in any sub command of eventgrid~ #Resolved
Contributor
Author
There was a problem hiding this comment.
Can you add tests for new added parameters?
evelyn-ys
reviewed
Mar 30, 2021
Member
evelyn-ys
left a comment
evelyn-ys
left a comment
There was a problem hiding this comment.
Can you add tests for new added parameters?
evelyn-ys
reviewed
Mar 30, 2021
…Azure/azure-cli into vkukke/deliveryattrib+topickind
Contributor
Author
yes. in a separate PR as it requires some setup. |
evelyn-ys
approved these changes
Mar 30, 2021
kairu-ms
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for delivery attribute
az eventgrid event-subscription create --name es1 --source-resource-id --endpoint --delivery-attribute-mapping staticattribname static staticattribvalue --delivery-attribute-mapping staticattribname2 static staticattribvalue2 true --delivery-attribute-mapping dynamicattribname dynamic dynamicattribvalue
az eventgrid event-subscription update --name es1 --source-resource-id --delivery-attribute-mapping staticattribname static staticattribvalue --delivery-attribute-mapping staticattribname2 static staticattribvalue2 true --delivery-attribute-mapping dynamicattribname dynamic dynamicattribvalue
These commands are exposed on az eventgrid partner topic event-subscription and az eventgrid system-topic event-subscription as well.
Get static attribute secrets
az eventgrid event-subscription show --name es1 --include-static-attribute-secret
Add support for creating topic for azure or azurearc
az eventgrid topic create -n -g --kind azure
az eventgrid topic create -n -g --kind azurearc --extended-location-name --extended-location-type customlocation
History Notes
[EventGrid] az eventgrid [partner topic | system-topic] event-subscription: Add support for delivery attribute
[EventGrid] az eventgrid topic create: Add support for creating topic for azure or azurearc