Skip to content

{storage} Add record_only() for tests needing additional configuration #17523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Juliehzl merged 2 commits into from
Mar 31, 2021
Merged

{storage} Add record_only() for tests needing additional configuration #17523

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60c3657
add record_only
Juliehzl Mar 31, 2021
aef6439
add record only
Juliehzl Mar 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...zure-cli/azure/cli/command_modules/storage/tests/latest/test_storage_account_scenarios.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
import unittest

from azure.cli.testsdk import (ScenarioTest, LocalContextScenarioTest, JMESPathCheck, ResourceGroupPreparer,
StorageAccountPreparer, api_version_constraint, live_only, LiveScenarioTest)
StorageAccountPreparer, api_version_constraint, live_only, LiveScenarioTest,
record_only)
from azure.cli.testsdk.decorators import serial_test
from azure.cli.core.profiles import ResourceType
from ..storage_test_util import StorageScenarioMixin
Expand Down Expand Up @@ -581,6 +582,7 @@ def test_renew_account_key(self, resource_group, storage_account):
assert renewed_keys[0] == original_keys[0]
assert renewed_keys[1] != original_keys[1]

@record_only() # Need to configure domain service first
@api_version_constraint(ResourceType.MGMT_STORAGE, min_api='2019-04-01')
@ResourceGroupPreparer()
def test_renew_account_kerb_key(self, resource_group):
Expand Down Expand Up @@ -741,6 +743,7 @@ def test_management_policy(self, resource_group, storage_account):
self.cmd('storage account management-policy delete --account-name {sa} -g {rg}')
self.cmd('storage account management-policy show --account-name {sa} -g {rg}', expect_failure=True)

@record_only() # Need to configure domain service first
@api_version_constraint(ResourceType.MGMT_STORAGE, min_api='2019-04-01')
@ResourceGroupPreparer()
def test_update_storage_account_with_files_aadds(self, resource_group):
Expand All @@ -767,6 +770,7 @@ def test_update_storage_account_with_files_aadds_false(self, resource_group):
self.assertIn('azureFilesIdentityBasedAuthentication', result)
self.assertEqual(result['azureFilesIdentityBasedAuthentication']['directoryServiceOptions'], 'None')

@record_only() # Need to configure domain service first
@api_version_constraint(ResourceType.MGMT_STORAGE, min_api='2019-04-01')
@ResourceGroupPreparer()
def test_update_storage_account_with_files_aadds_true(self, resource_group):
Expand All @@ -780,6 +784,7 @@ def test_update_storage_account_with_files_aadds_true(self, resource_group):
self.assertIn('azureFilesIdentityBasedAuthentication', result)
self.assertEqual(result['azureFilesIdentityBasedAuthentication']['directoryServiceOptions'], 'AADDS')

@record_only() # Need to configure domain service first
@api_version_constraint(ResourceType.MGMT_STORAGE, min_api='2019-04-01')
@ResourceGroupPreparer()
def test_create_storage_account_with_files_aadds(self, resource_group):
Expand All @@ -800,6 +805,7 @@ def test_create_storage_account_with_files_aadds_false(self, resource_group):
self.assertIn('azureFilesIdentityBasedAuthentication', result)
self.assertEqual(result['azureFilesIdentityBasedAuthentication']['directoryServiceOptions'], 'None')

@record_only() # Need to configure domain service first
@api_version_constraint(ResourceType.MGMT_STORAGE, min_api='2019-04-01')
@ResourceGroupPreparer()
def test_create_storage_account_with_files_aadds_true(self, resource_group):
Expand Down