{HDInsight}Use getting default sku api to set workernode and headnode size if customer does not provide #17552
Conversation
aim-for-better
changed the title
|
HDInsight |
There was a problem hiding this comment.
In this way, you will change default value for your CLI parameter, which is breaking. Is it by design?
There was a problem hiding this comment.
In this way, you will change default value for your CLI parameter, which is breaking. Is it by design?
Yes, we want to do this, but I forget it is a breaking change. This change will not have any impact on existing scripts, yes but it will change the parameter help info. Can we check in in this release cycle?
There was a problem hiding this comment.
It is not a good experience for customer to have such breaking change in stable azure cli. Is there strong business justification for such breaking change?
There was a problem hiding this comment.
It is not a good experience for customer to have such breaking change in stable azure cli. Is there strong business justification for such breaking change?
Because at before the default value is large, and it will be converted into some concrete value. As time goes, we will deprecate some vm size this will cause issue. If it is not acceptable for this release, it also makes sense for us. And when is the next release which accepts breaking change?
There was a problem hiding this comment.
S187 - 05/25/2021 release cycle could accept breaking change. CLI only accepts breaking change twice a year.
There was a problem hiding this comment.
S187 - 05/25/2021 release cycle could accept breaking change. CLI only accepts breaking change twice a year.
Hi @yonzhan Thanks. Then this PR will target at S187, and I will announce there will be breaking change in S186. You can skip this PR in this S185. Thank you~
aim-for-better
force-pushed
the
UsingGetSKUAPI
branch
from
6549eb2 to
0a73343
Compare
|
Please fix conflicts and update History Notes in PR comments. |
aim-for-better
force-pushed
the
UsingGetSKUAPI
branch
from
0a73343 to
bdea8f7
Compare
aim-for-better
force-pushed
the
UsingGetSKUAPI
branch
from
d530cf8 to
193217e
Compare
|
@aim-for-better could you make CI pass asap? |
6 participants
Description
Use gettting default sku api to set workernode and headnode size if customer does not provide explictly
Testing Guide
History Notes
[HDInsight] BREAKING CHANGE: az hdinsight create: Use getting default sku api to set workernode and headnode size if customer does not provide.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.