Skip to content

Conversation

@rosanch
Copy link
Contributor

@rosanch rosanch commented Apr 12, 2021

Description
The PR #17566 was merged before all comments were resolved. I need to remove a validation check from the command before release.

This checklist is used to make sure that common guidelines for a pull request are followed.

@rosanch
Copy link
Contributor Author

rosanch commented Apr 12, 2021

@fengzhou-msft can you review, please? There was pr merged before I could apply the changes

Copy link
Member

@northtyphoon northtyphoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rosanch
Copy link
Contributor Author

rosanch commented Apr 13, 2021

@fengzhou-msft is there any chance we can get this in the release?

@fengzhou-msft
Copy link
Member

@rosanch please change the target branch to be release branch. We will have a hotfix release next Monday.

@fengzhou-msft
Copy link
Member

Code merged in Hotfix PR #17749 and will be merged back into dev branch after hotfix release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants