{KeyVault} Bump keyvault mgmt sdk version to 2021-04-01-preview #17679
Conversation
houk-ms
requested review from
Juliehzl,
evelyn-ys,
fengzhou-msft,
jiasli and
jsntcy
as code owners
|
The PR is based on private package. We need hold the PR until the The PR can be merged after the official SDK is released and CI passes. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
houk-ms
requested review from
aim-for-better,
idear1203,
jaredmoo and
kairu-ms
as code owners
houk-ms
requested review from
msyyc,
qwordy,
sunsw1994,
v-Ajnava and
zhoxing-ms
as code owners
| - AZURECLI/2.21.0 azsdk-python-azure-mgmt-keyvault/8.0.0 Python/3.7.4 (Windows-10-10.0.19041-SP0) | ||
| method: PUT | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_disk_encryption_set_update_000001/providers/Microsoft.KeyVault/vaults/vault1-000002?api-version=2019-09-01 | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_disk_encryption_set_update_000001/providers/Microsoft.KeyVault/vaults/vault1-000002?api-version=2021-04-01-preview |
There was a problem hiding this comment.
Please make sure it can pass, or mark it if it fails. I do not recommend editing recording file. Just run it.
There was a problem hiding this comment.
sure, i will rerun live test for all the test related
|
All the tests were lively runned. Except for the following cases. The following live tests also failed in live test pipeline. We modified their API version directly.
The following tests are record-only. We modified their API version directly.
|
| ResourceType.MGMT_RESOURCE_TEMPLATESPECS: '2019-06-01-preview', | ||
| ResourceType.MGMT_NETWORK_DNS: '2018-05-01', | ||
| ResourceType.MGMT_KEYVAULT: '2020-04-01-preview', | ||
| ResourceType.MGMT_KEYVAULT: '2021-04-01-preview', |
There was a problem hiding this comment.
It is not reasonable to mark az keyvault as GA while the underlying API is preview, not to mention 2021-04-01-preview doesn't even have REST API doc:
https://docs.microsoft.com/en-us/rest/api/keyvault/vaults/get
Due to the lack of REST API doc, there will be no customer-facing document for CLI's output format either (#17332).
There was a problem hiding this comment.
This is more like a problem across all CLI command modules. I don't have a good idea about this
| self.check('privateLinkServiceConnectionState.status', 'Approved'), | ||
| self.check('privateLinkServiceConnectionState.description', '{approval_desc}'), | ||
| self.check('provisioningState', 'Succeeded') | ||
| self.check('provisioningState', 'Updating') |
There was a problem hiding this comment.
It looks like the state could be both:
| self.check('provisioningState', 'Updating') | |
| self.check_pattern('provisioningState', '(?:Updating|Succeeded)') |
There was a problem hiding this comment.
Interesting, how does it work? (?:Updating|Succeeded). Locally tested it, seems it can not make the test pass.
11 participants
Description
To support the new features for MHSM (soft-delete, private link, etc.), we have to upgrade the keyvault management sdk api version to
2021-04-01-preview.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.