Skip to content

Conversation

@DaeunYim
Copy link
Contributor

@DaeunYim DaeunYim commented Apr 19, 2021

Description

  • PostgreSQL server created with private network access (Vnet and subnet) will be using private DNS zone from GA.
  • az postgres flexible-server create/restore commands are updated.
  • Enable database name for create command
  • Enable check server name availability for create command

Testing Guide

History Notes

[RDBMS] BREAKING CHANGE: az mysql flexible-server create command parameter --storage-size default value is changed from 10 to 32.
[RDBMS] az postgres flexible-server create command added --private-dns-zone parameter for creating server with private access.

This checklist is used to make sure that common guidelines for a pull request are followed.

@DaeunYim
Copy link
Contributor Author

Create command without Private DNS zone support will not be supported post GA of flexible server. Is there any way we can guide the customers to upgrade the CLI version?

@yonzhan yonzhan added this to the S186 milestone Apr 19, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 19, 2021

@Juliehzl @evelyn-ys to help with

@Juliehzl
Copy link
Contributor

Create command without Private DNS zone support will not be supported post GA of flexible server. Is there any way we can guide the customers to upgrade the CLI version?

@DaeunYim We cannot change behavior for existing Azure CLI users. As you mentioned, without Private DNS zone will not be support. Does it mean without private DNS parameter, previous command will fail?

@DaeunYim
Copy link
Contributor Author

users. As you mentioned, without Private DNS zone will not be support. Does it mean without private DNS para

Yes post GA it will eventually be deprecated. Let me communicate with the backend team to give a good actionable error on this..

@DaeunYim
Copy link
Contributor Author

DaeunYim commented Apr 21, 2021

This PR needs new Python SDK release. I have updated and checked the tests are passing with the locally generated SDK. Let me work with the SDK release vendor and add the version once it's done,,

@DaeunYim
Copy link
Contributor Author

Confirmed all failing tests are due to fault in latest Python SDK version. Let me work on it as soon as the new SDK is out,,

@Juliehzl
Copy link
Contributor

Juliehzl commented Apr 29, 2021

users. As you mentioned, without Private DNS zone will not be support. Does it mean without private DNS para

Yes post GA it will eventually be deprecated. Let me communicate with the backend team to give a good actionable error on this..

Hi @DaeunYim, as there are thousands of command invocation for flexible-server create, typically such breaking change is not allowed because it will breaking existing customers, especially automation task and we need to follow Azure CLI breaking change process. Azure CLI allows breaking change twice a year and the latest one is for build. Could we make the breaking change in S187 release?

@Juliehzl Juliehzl merged commit b0bc536 into Azure:dev Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants