Skip to content

Conversation

@qwordy
Copy link
Member

@qwordy qwordy commented Apr 20, 2021

Description

Resolve #17656
Resolve #17599

disk create, 2 new parameters, --security-type, --support-hibernation

Fix a field name error. It is caused by a SDK breaking change. hyper_vgeneration became hyper_v_generation

Testing Guide

        self.cmd('disk create -g {rg} -n d1 --image-reference Canonical:UbuntuServer:18.04-LTS:18.04.202002180 --security-type TrustedLaunch', checks=[
            self.check('securityProfile.securityType', 'TrustedLaunch')
        ])
        self.cmd('disk create -g {rg} -n d1 --size-gb 10 --support-hibernation true', checks=[
            self.check('supportsHibernation', True)
        ])

History Notes

[Compute] disk create: Trusted launch
[Compute] disk create: Hibernation


This checklist is used to make sure that common guidelines for a pull request are followed.

@qwordy qwordy requested review from houk-ms and yungezz as code owners April 20, 2021 05:51
@qwordy qwordy added this to the S186 milestone Apr 20, 2021
@qwordy qwordy changed the title [Compute] disk create: Trusted launch; Hibernation [Compute] disk create: Trusted launch; [Compute] disk create: Hibernation Apr 21, 2021

if hyper_v_generation:
disk.hyper_vgeneration = hyper_v_generation
disk.hyper_v_generation = hyper_v_generation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that there are still many unnoticed but ubiquitous attribute/model/function-name error caused by track2 upgrading.
Is it necessary to check them thoroughly in advance rather than fix them after issues raising?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. It is a disadvantage of dynamic language. We can't detect the error until runtime.

@qwordy qwordy requested a review from fengzhou-msft April 22, 2021 06:46
Copy link
Contributor

@houk-ms houk-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qwordy qwordy merged commit de212eb into Azure:dev Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for DiskRP 2020-12-01 changes Trusted Launch - DiskRP CLI

3 participants