Skip to content

Conversation

@andyzhangx
Copy link
Contributor

@andyzhangx andyzhangx commented Apr 22, 2021

Description

az aks create: add enable-encryption-at-host parameter

Testing Guide

docker run -v ${HOME}:/root -it andyzhangx/azure-cli:2.22.1
az aks create -g $RESOURCE_GROUP_NAME -n $CLUSTER_NAME --node-count 1 --node-vm-size Standard_DS2_v2 --generate-ssh-keys --kubernetes-version 1.20.2 --enable-encryption-at-host
az aks nodepool add --name nodepool2 --cluster-name $CLUSTER_NAME --resource-group $RESOURCE_GROUP_NAME --enable-encryption-at-host

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@andyzhangx

This comment has been minimized.

1 similar comment
@andyzhangx
Copy link
Contributor Author

I already added exception rules in linter_exclusions.yml, not sure why it still failed:

2021-04-22T03:48:24.7236220Z -  FAIL - HIGH severity: option_length_too_long
2021-04-22T03:48:24.7237497Z     Parameter: aks create, `enable_encryption_at_host` - The lengths of all options ['--enable-encryption-at-host'] are longer than threshold 22. Argument enable_encryption_at_host must have a short abbreviation.
2021-04-22T03:48:24.7238773Z     Parameter: aks nodepool add, `enable_encryption_at_host` - The lengths of all options ['--enable-encryption-at-host'] are longer than threshold 22. Argument enable_encryption_at_host must have a short abbreviation.

@andyzhangx andyzhangx force-pushed the aks-encryption-at-host2 branch from f723189 to c61b6b0 Compare April 22, 2021 07:26
@andyzhangx andyzhangx force-pushed the aks-encryption-at-host2 branch from c61b6b0 to faceb04 Compare April 22, 2021 07:36
@andyzhangx
Copy link
Contributor Author

@fengzhou-msft would you help review? thanks.

@andyzhangx
Copy link
Contributor Author

@qwordy could you help review? thanks.

@andyzhangx
Copy link
Contributor Author

@qwordy can you merge this PR? thanks.

@fengzhou-msft fengzhou-msft merged commit 561240a into Azure:dev Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants