Skip to content

[HDInsight] Add Incoming BREAKING CHANGE for removing default value of --workernode-size and --headnode-size #17862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kairu-ms merged 28 commits into from
Apr 26, 2021
Merged

[HDInsight] Add Incoming BREAKING CHANGE for removing default value of --workernode-size and --headnode-size #17862

Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
00b9235
{Docs} Remove stale reference in README to closed issue about extensi…
dkmiller Apr 27, 2020
ab16df0
Merge remote-tracking branch 'upstream/release'
azclibot Apr 28, 2020
03436bc
Merge remote-tracking branch 'upstream/release'
azclibot Apr 30, 2020
7d98b1f
Merge remote-tracking branch 'upstream/release'
azclibot May 19, 2020
06f6ec5
Merge remote-tracking branch 'upstream/release'
azclibot Jun 2, 2020
adab2d2
Merge remote-tracking branch 'upstream/release'
azclibot Jun 23, 2020
c7b9f98
Merge remote-tracking branch 'upstream/release'
azclibot Jul 14, 2020
18e8b8d
Merge remote-tracking branch 'upstream/release'
azclibot Jul 16, 2020
1eb5074
Merge remote-tracking branch 'upstream/release'
azclibot Aug 4, 2020
cc3a159
Merge remote-tracking branch 'upstream/release' into master
azclibot Aug 6, 2020
af8f98e
Merge remote-tracking branch 'upstream/release' into master
azclibot Aug 26, 2020
0f904b9
Merge remote-tracking branch 'upstream/release' into master
azclibot Aug 28, 2020
d17a993
Merge remote-tracking branch 'upstream/release' into master
azclibot Sep 22, 2020
331b406
Merge branch 'master' of github.com:Azure/azure-cli into dev
Sep 24, 2020
c98c195
Merge branch 'dev' of github.com:Azure/azure-cli into dev
Sep 25, 2020
ee648a0
Merge branch 'dev' of github.com:Azure/azure-cli into dev
Nov 5, 2020
d2faa9f
Merge branch 'dev' of github.com:Azure/azure-cli into dev
Nov 9, 2020
64d0de4
Merge branch 'dev' of github.com:Azure/azure-cli into dev
Nov 10, 2020
7b250f5
Merge branch 'dev' of github.com:Azure/azure-cli into dev
Nov 18, 2020
03c8785
Merge branch 'dev' of github.com:Azure/azure-cli into dev
Dec 1, 2020
2f814b1
Merge branch 'dev' of github.com:Azure/azure-cli into dev
Dec 7, 2020
82ce0cc
Merge branch 'dev' of github.com:Azure/azure-cli into dev
Jan 29, 2021
3731883
Merge branch 'dev' of github.com:Azure/azure-cli into dev
Mar 18, 2021
1e48381
Merge branch 'dev' of github.com:Azure/azure-cli into dev
Apr 2, 2021
b50a530
Merge branch 'dev' of github.com:Azure/azure-cli into dev
Apr 25, 2021
15a1cef
Merge branch 'dev' of github.com:Azure/azure-cli into dev
Apr 26, 2021
5ae3694
Add Incoming BREAKING CHANGE.
Apr 26, 2021
d00644d
Add incoming change in long-summary part.
Apr 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/azure-cli/azure/cli/command_modules/hdinsight/_help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@

helps['hdinsight create'] = """
type: command
short-summary: Create a new cluster.
short-summary: 'Create a new cluster. Incoming BREAKING CHANGE: The default value "large" of parameters
`--workernode-size` and `--headnode-size` will be removed in the next CLI version.'
Copy link
Contributor

@Juliehzl Juliehzl Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use long-summary for BREAKING CHANGE part.

Copy link
Member Author

@aim-for-better aim-for-better Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

examples:
- name: Create a cluster with an existing storage account.
text: |-
Expand Down
10 changes: 8 additions & 2 deletions src/azure-cli/azure/cli/command_modules/hdinsight/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,14 @@ def load_arguments(self, _):
help='SSH public key for the cluster nodes.')

# Node
c.argument('headnode_size', arg_type=node_size_type)
c.argument('workernode_size', arg_type=node_size_type)
c.argument('headnode_size', arg_type=node_size_type,
help='Incoming BREAKING CHANGE: The default value "large" will be removed in next CLI version.'
'The size of the node. See also: https://docs.microsoft.com/azure/'
'hdinsight/hdinsight-hadoop-provision-linux-clusters#configure-cluster-size')
c.argument('workernode_size', arg_type=node_size_type,
help='Incoming BREAKING CHANGE: The default value "large" will be removed in next CLI version.'
'The size of the node. See also: https://docs.microsoft.com/azure/'
'hdinsight/hdinsight-hadoop-provision-linux-clusters#configure-cluster-size')
c.argument('workernode_data_disks_per_node', arg_group='Node',
help='The number of data disks to use per worker node.')
c.argument('workernode_data_disk_storage_account_type', arg_group='Node',
Expand Down