[AppService] BREAKING CHANGE: Add support for az staticwebapp show; az staticwebapp create; az staticwebapp update #17870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiansong-msft
changed the title
jiansong-msft
changed the title
miwebst
reviewed
Apr 26, 2021
src/azure-cli/azure/cli/command_modules/appservice/static_sites.py
Outdated
Show resolved
Hide resolved
miwebst
reviewed
Apr 26, 2021
miwebst
approved these changes
Apr 26, 2021
qwordy
reviewed
Apr 27, 2021
qwordy
approved these changes
Apr 27, 2021
Member
|
Minor issue, |
fix typo Co-authored-by: Feiyue Yu <[email protected]>
qwordy
changed the title
Juliehzl
reviewed
Apr 27, 2021
Juliehzl
reviewed
Apr 27, 2021
Juliehzl
reviewed
Apr 27, 2021
Juliehzl
reviewed
Apr 27, 2021
jiansong-msft
changed the title
jiansong-msft
changed the title
jiansong-msft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Guide
Tested commands - working as expected:
1. az staticwebapp show -n my-first-static-web-app
2. az staticwebapp create -n my-second-static-web-app -g rg -s https://github.com/jiansong-msft/my-first-static-web-app -l CentralUS -b main --token github-token --sku Free
3. az staticwebapp update -n my-second-static-web-app --tags "key=value"
4. az staticwebapp update -n static-app-not-exists throws
5. with invalid sku options passed in throws
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.