Skip to content

Conversation

@pzhlkj6612
Copy link
Contributor

Description

I found some words are concatenated by mistake.

"accessedusing" vs. "accessed using":

az storage blob generate-sas & az storage container generate-sas

Optional Parameters

--cache-control
Response header value for Cache-Control when resource is accessedusing this shared access signature.

--content-disposition
Response header value for Content-Disposition when resource is accessedusing this shared access signature.

--content-encoding
Response header value for Content-Encoding when resource is accessedusing this shared access signature.

--content-language
Response header value for Content-Language when resource is accessedusing this shared access signature.

--content-type
Response header value for Content-Type when resource is accessedusing this shared access signature.

"ofthis" vs. "of this":

az storage blob url

Optional Parameters

--snapshot
An string value that uniquely identifies the snapshot. The value ofthis query parameter indicates the snapshot version.

I fixed them.

History Notes

[Storage] az storage blob generate-sas: Add spaces to split the concatenated words in the help message of the arguments --cache-control, --content-disposition, --content-encoding, --content-language and --content-type.
[Storage] az storage blob url: Add a space to split the concatenated words in the help message of the argument --snapshot.
[Storage] az storage container generate-sas: Add spaces to split the concatenated words in the help message of the arguments --cache-control, --content-disposition, --content-encoding, --content-language and --content-type.


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label May 1, 2021
@ghost
Copy link

ghost commented May 1, 2021

Thank you for your contribution pzhlkj6612! We will review the pull request and get back to you soon.

@yonzhan yonzhan added this to the S187 milestone May 1, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented May 1, 2021

Storage

@pzhlkj6612
Copy link
Contributor Author

Oh, I'm sorry. I didn't notice the report from Pylint on CI:

ERROR: ************* Module azure.cli.command_modules.storage._params
src/azure-cli/azure/cli/command_modules/storage/_params.py:651:0: C0301: Line too long (121/120) (line-too-long)
src/azure-cli/azure/cli/command_modules/storage/_params.py:1150:0: C0301: Line too long (121/120) (line-too-long)
src/azure-cli/azure/cli/command_modules/storage/_params.py:651:0: C0301: Line too long (121/120) (line-too-long)
src/azure-cli/azure/cli/command_modules/storage/_params.py:1150:0: C0301: Line too long (121/120) (line-too-long)

@jiasli Thank you very much.

@jiasli
Copy link
Member

jiasli commented May 10, 2021

@pzhlkj6612, you are mostly welcome and thanks for the contribution. 😊

@jiasli jiasli changed the title [Storage] Split concatenated words in the help message {Storage} Split concatenated words in the help message May 10, 2021
@jiasli jiasli merged commit beb2bae into Azure:dev May 10, 2021
@pzhlkj6612 pzhlkj6612 deleted the split-words-in-help-storage branch May 10, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants