Skip to content

Conversation

@avanigupta
Copy link
Member

@avanigupta avanigupta commented May 6, 2021

Description

While importing key-values from a file, if the key or value contains a non-ASCII character, we fail to parse the file and throw syntax error. Since AppConfig allows unicode characters in key and values, we should be able to import them from file.

Reported in customer issue #513.

Testing Guide
Trying to import this json file with unicode characters should succeed:

{
  "User’s Name": "John",
  "Temperature": "98º",
  "Chinese": "汉"
}

az appconfig kv import -s file --format json --auth-mode login --endpoint https://test-appconfig-00.azconfig.io --path <filePath> --yes

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@avanigupta avanigupta requested a review from qwordy as a code owner May 6, 2021 22:15
@avanigupta
Copy link
Member Author

cc @shenmuxiaosen

@yonzhan
Copy link
Collaborator

yonzhan commented May 6, 2021

AppConfig

Copy link
Contributor

@shenmuxiaosen shenmuxiaosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@qwordy qwordy merged commit 855a283 into Azure:dev May 8, 2021
@avanigupta avanigupta deleted the avanigupta/ImportUnicodeStrings branch May 10, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants