[AKS] az aks create and update azure-rbac #18026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anumita
changed the title
Contributor
Author
|
@fengzhou-msft , could you help review and merge this PR? Review is done from the AKS side |
shashankbarsin
approved these changes
May 12, 2021
krdhruva
reviewed
May 12, 2021
krdhruva
reviewed
May 12, 2021
krdhruva
reviewed
May 12, 2021
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Show resolved
Hide resolved
krdhruva
reviewed
May 12, 2021
krdhruva
approved these changes
May 12, 2021
Contributor
Author
|
@fengzhou-msft , review is done from our side and are good to merge. I have resolved your comments as well. Could you review as well? |
fengzhou-msft
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to port the support of creating and updating AKS-managed cluster with Azure RBAC from aks-preview extension. It adds a new argument --enable-azure-rbac to az aks create command and --enable-azure-rbac and --disable-azure-rbac to the az aks update command
Testing Guide
Create an AKS-managed cluster with Azure RBAC
Update an AKS-managed Azure AD cluster
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.