Skip to content

[App Service] az staticwebapp appsettings set issue #17792 #18034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qwordy merged 1 commit into from
May 12, 2021
Merged

[App Service] az staticwebapp appsettings set issue #17792 #18034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/appservice/static_sites.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,8 @@ def _parse_pair(pair, delimiter):
if delimiter not in pair:
CLIError("invalid format of pair {0}".format(pair))

pair_split = pair.split(delimiter)
return pair_split[0], pair_split[1]
index = pair.index(delimiter)
return pair[:index], pair[1 + index:]


def _raise_missing_token_suggestion():
Expand Down
8 changes: 4 additions & 4 deletions ...li/azure/cli/command_modules/appservice/tests/latest/test_staticapp_commands_thru_mock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,17 +296,17 @@ def test_list_staticsite_function_app_settings_without_resourcegroup(self):
self.rg1, self.name1)

def test_set_staticsite_function_app_settings_with_resourcegroup(self):
app_settings1_input = ['key1=val1', 'key2=val2']
app_settings1_dict = {'key1': 'val1', 'key2': 'val2'}
app_settings1_input = ['key1=val1', 'key2=val2==', 'key3=val3=']
app_settings1_dict = {'key1': 'val1', 'key2': 'val2==', 'key3': 'val3='}

set_staticsite_function_app_settings(self.mock_cmd, self.name1, app_settings1_input, self.rg1)

self.staticapp_client.create_or_update_static_site_function_app_settings.assert_called_once_with(
self.rg1, self.name1, kind=None, properties=app_settings1_dict)

def test_set_staticsite_function_app_settings_without_resourcegroup(self):
app_settings1_input = ['key1=val1', 'key2=val2']
app_settings1_dict = {'key1': 'val1', 'key2': 'val2'}
app_settings1_input = ['key1=val1', 'key2=val2==', 'key3=val3=']
app_settings1_dict = {'key1': 'val1', 'key2': 'val2==', 'key3': 'val3='}
self.staticapp_client.list.return_value = [self.app1, self.app2]

set_staticsite_function_app_settings(self.mock_cmd, self.name1, app_settings1_input)
Expand Down