Skip to content

[IoT Hub] Track 2 updates and managed identity implementation #18098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yonzhan merged 12 commits into from
May 21, 2021
Merged

[IoT Hub] Track 2 updates and managed identity implementation #18098

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c75e60e
IoT Hub track 2 updates and managed identity implementation (#2)
c-ryan-k May 14, 2021
ef05589
Test recording updates with 2.0.0 SDK
c-ryan-k May 17, 2021
d6005a9
Fixes for hyrid profile commands / tests and iot_security tests
c-ryan-k May 17, 2021
5c394ee
String fixes from code review
c-ryan-k May 19, 2021
6164e87
Updated CLIErrors for missing params to use RequiredArgumentMissingError
c-ryan-k May 19, 2021
b4affcf
Merge branch 'azure-dev' into dev
c-ryan-k May 19, 2021
a38a985
Fix CLIError -> ArgumentUsageError
c-ryan-k May 19, 2021
44e6e20
Merge branch 'dev' of https://github.com/c-ryan-k/azure-cli into dev
c-ryan-k May 19, 2021
e9633f4
PR feedback and test updates
c-ryan-k May 19, 2021
d60a1a7
New format for managed identity parameters
c-ryan-k May 19, 2021
6fc1bfc
Fix wrong parameter in error description
c-ryan-k May 20, 2021
f8ec73d
Removed identity update command
c-ryan-k May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix wrong parameter in error description
  • Loading branch information
@c-ryan-k
c-ryan-k committed May 20, 2021
commit 6fc1bfc523c2fbd4deb5553e1c0d7147aec6dccc
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/iot/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,7 @@ def setter(hub):
if bool(identity_role) ^ bool(identity_scopes):
raise RequiredArgumentMissingError('At least one scope (--scopes) and one role (--role) required for system-managed identity role assignment.')
if not system_identity and not user_identities:
raise RequiredArgumentMissingError('No identities provided to assign. Please provide system (--system) or user-assigned identities (--user-identities).')
raise RequiredArgumentMissingError('No identities provided to assign. Please provide system (--system) or user-assigned identities (--user).')
if identity_role and identity_scopes:
from azure.cli.core.commands.arm import assign_identity
for scope in identity_scopes:
Expand All @@ -695,7 +695,7 @@ def iot_hub_identity_remove(cmd, client, hub_name, system_identity=None, user_id
hub_identity = hub.identity

if not system_identity and not user_identities:
raise RequiredArgumentMissingError('No identities provided to remove. Please provide system (--system) or user-assigned identities (--user-identities).')
raise RequiredArgumentMissingError('No identities provided to remove. Please provide system (--system) or user-assigned identities (--user).')
# Turn off system managed identity
if system_identity:
if hub_identity.type not in [
Expand Down