Skip to content

{Keyvault} Support managed HSM private link operations #18273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evelyn-ys merged 8 commits into from
Jun 1, 2021
Merged

{Keyvault} Support managed HSM private link operations #18273

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5fbb026
private link resource
evelyn-ys May 28, 2021
8449c75
private endpoint connection
evelyn-ys May 28, 2021
3615312
tests
evelyn-ys May 31, 2021
87041cb
network module tests
evelyn-ys May 31, 2021
fb17a58
Merge branch 'dev' into hsm_private_link
evelyn-ys May 31, 2021
f265c72
linter
evelyn-ys May 31, 2021
b676c23
Merge branch 'hsm_private_link' of https://github.com/evelyn-ys/azure…
evelyn-ys May 31, 2021
0e90b91
merge network changes
evelyn-ys May 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linter
  • Loading branch information
@evelyn-ys
evelyn-ys committed May 31, 2021
commit f265c72ec6b7f51701b0dbca1dc46aa1ac4e7060
14 changes: 7 additions & 7 deletions src/azure-cli/azure/cli/command_modules/keyvault/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1816,18 +1816,18 @@ def approve_private_endpoint_connection(cmd, client, resource_group_name, privat
vault_name=None, hsm_name=None, description=None, no_wait=False):
"""Approve a private endpoint connection request for a Key Vault."""
pec_client = _get_vault_or_hsm_pec_client(cmd, client, vault_name, hsm_name)
return _update_private_endpoint_connection_status(
cmd, pec_client, resource_group_name, vault_name or hsm_name, private_endpoint_connection_name,
is_approved=True, description=description, no_wait=no_wait)
return _update_private_endpoint_connection_status(cmd, pec_client, resource_group_name,
vault_name or hsm_name, private_endpoint_connection_name,
is_approved=True, description=description, no_wait=no_wait)


def reject_private_endpoint_connection(cmd, client, resource_group_name, private_endpoint_connection_name,
vault_name=None, hsm_name=None, description=None, no_wait=False):
vault_name=None, hsm_name=None, description=None, no_wait=False):
"""Reject a private endpoint connection request for a Key Vault."""
pec_client = _get_vault_or_hsm_pec_client(cmd, client, vault_name, hsm_name)
return _update_private_endpoint_connection_status(
cmd, pec_client, resource_group_name, vault_name or hsm_name, private_endpoint_connection_name,
is_approved=False, description=description, no_wait=no_wait)
return _update_private_endpoint_connection_status(cmd, pec_client, resource_group_name,
vault_name or hsm_name, private_endpoint_connection_name,
is_approved=False, description=description, no_wait=no_wait)


def delete_private_endpoint_connection(cmd, client, resource_group_name, private_endpoint_connection_name,
Expand Down