[ACR] Fix some bugs on uncovered cmds #18831
Conversation
rosanch
requested review from
Juliehzl,
northtyphoon and
zhoxing-ms
as code owners
|
ACR |
|
LGTM |
|
There are no any recorded yaml files here. May I ask have you rerun the relevant tests? |
|
By the way, the reason why these bugs have not been found before is because the tests do not cover these cases? If so, please add relevant tests~ |
zhoxing-ms
left a comment
zhoxing-ms
left a comment
There was a problem hiding this comment.
I'd like to ask is this PR for hotfix? If so, please submit hotfix related PRs to the release branch. Please refer to this document for details doc link
|
Connected-registry currently has no test at all. |
rosanch
requested review from
digimaun,
evelyn-ys,
jiasli,
kairu-ms and
temandr
as code owners
|
@zhoxing-ms we want to include this in the hot release. But on top of the PR #18786 and I don't see that merged to the release branch. Wouldn't it make some merge conflict if I merge this change first? |
00Kai0
requested review from
aim-for-better,
andyliuliming,
bgklein and
dbradish-microsoft
as code owners
00Kai0
requested review from
dpwatrous,
fengzhou-msft,
gingi,
houk-ms,
jaredmoo,
msyyc,
panchagnula,
paterasMSFT,
qwordy,
yungezz and
zqingqing1
as code owners
|
This change has been merged into the release branch by #18853. After hotfix is released, we will merge back to the dev branch, so close this PR first |
|
Close it, because PR #18853 has included it. |
6 participants
Description
I was still able to find some bugs related to the SDK update.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.