Skip to content

[Role] BREAKING CHANGE: az ad sp create-for-rbac: Drop name property from the output #19808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 3 commits into from
Dec 10, 2021
Merged

[Role] BREAKING CHANGE: az ad sp create-for-rbac: Drop name property from the output #19808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04672ce
Drop name property
jiasli Oct 8, 2021
b4869a1
Fix tests
jiasli Oct 8, 2021
9b18494
Merge remote-tracking branch 'azure/dev' into rbac-drop-name
jiasli Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/azure-cli/azure/cli/command_modules/role/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@
"If needed, use the --role argument to explicitly create a role assignment."
)

NAME_DEPRECATION_WARNING = \
"'name' property in the output is deprecated and will be removed in the future. Use 'appId' instead."

logger = get_logger(__name__)

# pylint: disable=too-many-lines
Expand Down Expand Up @@ -1500,7 +1497,6 @@ def create_service_principal_for_rbac(
raise

logger.warning(CREDENTIAL_WARNING)
logger.warning(NAME_DEPRECATION_WARNING)

if show_auth_for_sdk:
from azure.cli.core._profile import Profile
Expand All @@ -1514,7 +1510,6 @@ def create_service_principal_for_rbac(
result = {
'appId': app_id,
'password': password,
'name': app_id,
'displayName': app_display_name,
'tenant': graph_client.config.tenant_id
}
Expand Down
1 change: 0 additions & 1 deletion src/azure-cli/azure/cli/command_modules/role/tests/latest/test_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ def test_sp_create_scenario(self):
result = self.cmd('ad sp create-for-rbac -n {display_name} --skip-assignment',
checks=self.check('displayName', '{display_name}')).get_output_in_json()

self.assertEqual(result['name'], result['appId'])
self.kwargs['app_id'] = result['appId']

# show/list app
Expand Down
1 change: 0 additions & 1 deletion src/azure-cli/azure/cli/command_modules/role/tests/latest/test_role.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ def test_create_for_rbac_with_right_display_name(self):

try:
sp_info = self.cmd('ad sp create-for-rbac -n {display_name} --skip-assignment').get_output_in_json()
self.assertTrue(sp_info['name'] == sp_info['appId'])
self.assertTrue(sp_info['displayName'] == sp_name)
self.kwargs['app_id'] = sp_info['appId']

Expand Down
2 changes: 0 additions & 2 deletions src/azure-cli/azure/cli/command_modules/role/tests/latest/test_role_commands_thru_mock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ def test_create_for_rbac_password_plumbed_through(self, graph_client_mock, auth_
result = create_service_principal_for_rbac(cmd, name, 12, skip_assignment=True)

# assert
self.assertEqual(result['name'], test_app_id)
self.assertEqual(result['displayName'], name)
self.assertEqual(result['appId'], test_app_id)

Expand Down Expand Up @@ -175,7 +174,6 @@ def mock_app_create(parameters):
result = create_service_principal_for_rbac(cmd, name, cert=cert, years=2, skip_assignment=True)

# assert
self.assertEqual(result['name'], test_app_id)
self.assertEqual(result['appId'], test_app_id)
self.assertTrue(logger_mock.warning.called) # we should warn 'years' will be dropped
self.assertTrue(faked_graph_client.applications.create.called)
Expand Down