-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[HDInsight] Support az and private link per new api20210601 #20060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kairu-ms
merged 33 commits into
Azure:dev
from
aim-for-better:SupportAzAndPrivateLinkPerNewApi20210601
Oct 27, 2021
Merged
[HDInsight] Support az and private link per new api20210601 #20060
kairu-ms
merged 33 commits into
Azure:dev
from
aim-for-better:SupportAzAndPrivateLinkPerNewApi20210601
Oct 27, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es and private link configurations feature
kairu-ms
approved these changes
Oct 27, 2021
Contributor
kairu-ms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on Code. Please fix CI issues. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade the python sdk dependency and add two parameters "--zones" and "--private-link-configurations" in az hdinsight create command
Testing Guide
Rerun all tests and add news tests for new added parameters
History Notes
[HDInsight] az hdinsight create: add two parameters "--zones" and "--private-link-configurations" to support creating cluster with availability zones feature and creating private link enabled cluster with private link configurations feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.