[AKS] az aks create, aks nodepool add: Add --kubelet-config and --linux-os-config to support custom node configuration
#21722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeldeib
requested review from
andyliuliming,
jsntcy and
zhoxing-ms
as code owners
ghost
requested a review
from 
ghost
assigned
alexeldeib
force-pushed
the
ace/customnode
branch
from
82f6335 to
afc3db3
Compare
Collaborator
|
AKS |
wangzelin007
changed the title
az aks create, aks nodepool add: Add --kubelet-config/--linux-os-config to support custom node configuration
alexeldeib
changed the title
az aks create, aks nodepool add: Add --kubelet-config/--linux-os-config to support custom node configurationaz aks create, aks nodepool add: Add --kubelet-config and --linux-os-config to support custom node configuration
Contributor
Author
|
/azp list |
|
Commenter does not have sufficient privileges for PR 21722 in repo Azure/azure-cli |
Contributor
Author
|
@FumingZhang mind taking a look? |
FumingZhang
reviewed
Mar 28, 2022
Member
There was a problem hiding this comment.
I am not sure if it's better to remind the user that this should be the path to a json format configuration file.
Member
There was a problem hiding this comment.
Also a link indicates what properties/options the configuration file can have?
added 11 commits
March 28, 2022 20:53
alexeldeib
force-pushed
the
ace/customnode
branch
from
3e49dd8 to
8e05cbf
Compare
Contributor
Author
|
hmm, not sure about that last one? it's not in my code, but the error is too many local vars, yet it's on a function definition? https://github.com/Azure/azure-cli/blob/dev/src/azure-cli/azure/cli/command_modules/serviceconnector/custom.py#L244 |
Member
|
The CI failure is fixed by PR #21826. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
wangzelin007
approved these changes
Mar 30, 2022
zhoxing-ms
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add custom node config for AKS
Testing Guide
Added live test example
History Notes
[AKS]
az aks create: Add--kubelet-configand--linux-os-configto support custom node configuration[AKS]
az aks nodepool add: Add--kubelet-configand--linux-os-configto support custom node configurationThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.